You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "chandrasekhar-188k (via GitHub)" <gi...@apache.org> on 2025/03/08 14:54:40 UTC
[PR] HBASE-29175 Avoid index based field sorting in tablesorter in table.jsp [hbase]
chandrasekhar-188k opened a new pull request, #6773:
URL: https://github.com/apache/hbase/pull/6773
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29175 Avoid index based field sorting in tablesorter in table.jsp [hbase]
Posted by "chandrasekhar-188k (via GitHub)" <gi...@apache.org>.
chandrasekhar-188k commented on PR #6773:
URL: https://github.com/apache/hbase/pull/6773#issuecomment-2708339184
[Meta table.docx](https://github.com/user-attachments/files/19144234/Meta.table.docx)
[UserTable_Test.docx](https://github.com/user-attachments/files/19144235/UserTable_Test.docx)
UI Test results after the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29175 Avoid index based field sorting in tablesorter in table.jsp [hbase]
Posted by "chandrasekhar-188k (via GitHub)" <gi...@apache.org>.
chandrasekhar-188k commented on PR #6773:
URL: https://github.com/apache/hbase/pull/6773#issuecomment-2710706613
> All 3 PRs LGTM, thanks for the fix @chandrasekhar-188k.
>
> * [HBASE-29175 Avoid index based field sorting in tablesorter in table.jsp #6773](https://github.com/apache/hbase/pull/6773)
> * [HBASE-29176 Avoid index based field sorting in tablesorter in master-status page #6774](https://github.com/apache/hbase/pull/6774)
> * [HBASE-29177 Avoid index based field sorting in tablesorter in rs-status page #6775](https://github.com/apache/hbase/pull/6775)
>
> Is it possible for you please merge all the changes in a single PR/JIRA? Change looks small enough, and against the effort of backporting each PR/JIRA independently.
yeah, the changes are small, i will merged into single PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29175 Avoid index based field sorting in tablesorter in table.jsp [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6773:
URL: https://github.com/apache/hbase/pull/6773#issuecomment-2708350947
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 28s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
|||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 17s | | master passed |
| +1 :green_heart: | spotless | 0m 45s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 4s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | spotless | 0m 44s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 10s | | The patch does not generate ASF License warnings. |
| | | 9m 52s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6773/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6773 |
| Optional Tests | dupname asflicense javac codespell detsecrets spotless |
| uname | Linux 7719b9523c63 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 3b25091101f576b162b29543f1a637b6c1ead694 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 81 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6773/1/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29175 Avoid index based field sorting in tablesorter in table.jsp [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6773:
URL: https://github.com/apache/hbase/pull/6773#issuecomment-2709618006
All 3 PRs LGTM, thanks for the fix @chandrasekhar-188k. Is it possible for you please merge all the changes in a single PR/JIRA? Change looks small enough, and against the effort of backporting each PR/JIRA independently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29175 Avoid index based field sorting in tablesorter in table.jsp [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain closed pull request #6773: HBASE-29175 Avoid index based field sorting in tablesorter in table.jsp
URL: https://github.com/apache/hbase/pull/6773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29175 Avoid index based field sorting in tablesorter in table.jsp [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6773:
URL: https://github.com/apache/hbase/pull/6773#issuecomment-2708447526
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 30s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 18s | | master passed |
| +1 :green_heart: | javadoc | 0m 28s | | master passed |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 5s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 27s | | the patch passed |
|||| _ Other Tests _ |
| -1 :x: | unit | 218m 8s | [/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6773/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt) | hbase-server in the patch failed. |
| | | 230m 42s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6773/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6773 |
| Optional Tests | javac javadoc unit |
| uname | Linux f28b042edf0b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 3b25091101f576b162b29543f1a637b6c1ead694 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6773/1/testReport/ |
| Max. process+thread count | 5164 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6773/1/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29175 Avoid index based field sorting in tablesorter in table.jsp [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6773:
URL: https://github.com/apache/hbase/pull/6773#issuecomment-2712979109
Superseded by https://github.com/apache/hbase/pull/6779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29175 Avoid index based field sorting in tablesorter in table.jsp [hbase]
Posted by "chandrasekhar-188k (via GitHub)" <gi...@apache.org>.
chandrasekhar-188k commented on PR #6773:
URL: https://github.com/apache/hbase/pull/6773#issuecomment-2710810490
> > All 3 PRs LGTM, thanks for the fix @chandrasekhar-188k.
> >
> > * [HBASE-29175 Avoid index based field sorting in tablesorter in table.jsp #6773](https://github.com/apache/hbase/pull/6773)
> > * [HBASE-29176 Avoid index based field sorting in tablesorter in master-status page #6774](https://github.com/apache/hbase/pull/6774)
> > * [HBASE-29177 Avoid index based field sorting in tablesorter in rs-status page #6775](https://github.com/apache/hbase/pull/6775)
> >
> > Is it possible for you please merge all the changes in a single PR/JIRA? Change looks small enough, and against the effort of backporting each PR/JIRA independently.
>
> yeah, the changes are small, i will merge into single PR.
merged the changes to single PR: https://github.com/apache/hbase/pull/6779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org