You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/06/28 19:42:16 UTC
[GitHub] [cassandra-sidecar] frankgh opened a new pull request, #30: CASSANDRASC-38 Add endpoint to list snapshot files
frankgh opened a new pull request, #30:
URL: https://github.com/apache/cassandra-sidecar/pull/30
This commit adds two new endpoints to allow listing snapshot files.
The first endpoint takes a snapshot name as a path parameter, and searches for
all the snapshots matching the provided name. The result lists all the snapshot
files for all matching snapshots. Additionally, secondary index files can be
included in the response by providing the query param
`includeSecondaryIndexFiles=true`.
```
/api/v1/snapshots/:snapshot
```
The second endpoint takes a keyspace, table name, and snapshot name and searches
for a unique snapshot matching the provided snapshot name in the given keyspace
and table name. The results lists the snapshot files matching the given keyspace,
table name, and snapshot name. Similarly to the first endpoint, secondary index
files can be included in the response by providing the query param
`includeSecondaryIndexFiles=true`.
```
/api/v1/keyspace/:keyspace/table/:table/snapshots/:snapshot
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-sidecar] frankgh closed pull request #30: CASSANDRASC-38 Add endpoint to list snapshot files
Posted by GitBox <gi...@apache.org>.
frankgh closed pull request #30: CASSANDRASC-38 Add endpoint to list snapshot files
URL: https://github.com/apache/cassandra-sidecar/pull/30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-sidecar] frankgh commented on a diff in pull request #30: CASSANDRASC-38 Add endpoint to list snapshot files
Posted by GitBox <gi...@apache.org>.
frankgh commented on code in PR #30:
URL: https://github.com/apache/cassandra-sidecar/pull/30#discussion_r908879071
##########
src/test/java/org/apache/cassandra/sidecar/snapshots/AbstractSnapshotPathBuilderTest.java:
##########
@@ -109,149 +129,16 @@ void setup() throws IOException
instance = initialize(vertx, mockInstancesConfig);
}
+ @SuppressWarnings("ResultOfMethodCallIgnored")
@AfterEach
void clear()
{
- assertThat(dataDir0.delete());
- assertThat(dataDir1.delete());
+ dataDir0.delete();
+ dataDir1.delete();
}
abstract SnapshotPathBuilder initialize(Vertx vertx, InstancesConfig instancesConfig);
- @Test
Review Comment:
these are really unit tests, moved them to `StreamSSTableComponentRequestTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org