You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by gi...@git.apache.org on 2017/09/15 13:13:44 UTC

[GitHub] fabianmenges commented on a change in pull request #3434: Feature/Fix: times_series limit for Druid

fabianmenges commented on a change in pull request #3434: Feature/Fix: times_series limit for Druid
URL: https://github.com/apache/incubator-superset/pull/3434#discussion_r139144926
 
 

 ##########
 File path: superset/connectors/druid/models.py
 ##########
 @@ -798,6 +798,28 @@ def values_for_column(self,
     def get_query_str(self, query_obj, phase=1, client=None):
         return self.run_query(client=client, phase=phase, **query_obj)
 
+    def _add_filter_from_pre_query_data(self, df, dimensions, filter):
+        ret = filter
 
 Review comment:
   ah... keep forgetting filter :(
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services