You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "LiJie20190102 (via GitHub)" <gi...@apache.org> on 2023/03/06 14:38:02 UTC
[GitHub] [dolphinscheduler] LiJie20190102 opened a new pull request, #13683: [Fix-13596][Task Instance] Throw an error message to tell the user th…
LiJie20190102 opened a new pull request, #13683:
URL: https://github.com/apache/dolphinscheduler/pull/13683
…at the file cannot be found instead of NPE during task execution
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
Throw an error message to tell the user that the file cannot be found instead of NPE during task execution.
## Related PR: #13596
## Brief change log
modify: org.apache.dolphinscheduler.service.process.ProcessServiceImpl#updateTaskDefinitionResources
modify: org.apache.dolphinscheduler.service.process.ProcessServiceImpl#updateResourceInfo
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
**if contains mainJar field:**
**if contains resourceList information:**
(or)
If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Radeity commented on a diff in pull request #13683: [Fix-13596][Task Instance] Throw an error message to tell the user th…
Posted by "Radeity (via GitHub)" <gi...@apache.org>.
Radeity commented on code in PR #13683:
URL: https://github.com/apache/dolphinscheduler/pull/13683#discussion_r1128908637
##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java:
##########
@@ -1810,6 +1808,10 @@ private ResourceInfo updateResourceInfo(ResourceInfo res) {
resourceInfo = new ResourceInfo();
// get resource from database, only one resource should be returned
Resource resource = getResourceById(resourceId);
+ if (Objects.isNull(resource)) {
+ logger.error("not found resource by resourceId:{} from t_ds_resources.", resourceId);
Review Comment:
```suggestion
logger.error("resource not found, resourceId: {}", resourceId);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] LiJie20190102 commented on pull request #13683: [Fix-13596][Task Instance] Throw an error message to tell the user th…
Posted by "LiJie20190102 (via GitHub)" <gi...@apache.org>.
LiJie20190102 commented on PR #13683:
URL: https://github.com/apache/dolphinscheduler/pull/13683#issuecomment-1463910182
@Radeity I only modified one file. Should I deal with these code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on pull request #13683: [Fix-13596][Task Instance] Throw an error message to tell the user th…
Posted by "fuchanghai (via GitHub)" <gi...@apache.org>.
fuchanghai commented on PR #13683:
URL: https://github.com/apache/dolphinscheduler/pull/13683#issuecomment-1457446941
> @SbloodyS @caishunfeng Whether #13678 should be associated with it
sorry， #13678 not the same problem,but have same exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #13683: [Fix-13596][Task Instance] Throw an error message to tell the user th…
Posted by "zhongjiajie (via GitHub)" <gi...@apache.org>.
zhongjiajie commented on code in PR #13683:
URL: https://github.com/apache/dolphinscheduler/pull/13683#discussion_r1155640834
##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java:
##########
@@ -1810,6 +1808,10 @@ private ResourceInfo updateResourceInfo(ResourceInfo res) {
resourceInfo = new ResourceInfo();
// get resource from database, only one resource should be returned
Resource resource = getResourceById(resourceId);
+ if (Objects.isNull(resource)) {
+ logger.error("resource not found, resourceId: {}", resourceId);
+ return null;
Review Comment:
can we directly throw the exception here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhuangchong closed pull request #13683: [Fix-13596][Task Instance] Throw an error message to tell the user th…
Posted by "zhuangchong (via GitHub)" <gi...@apache.org>.
zhuangchong closed pull request #13683: [Fix-13596][Task Instance] Throw an error message to tell the user th…
URL: https://github.com/apache/dolphinscheduler/pull/13683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] LiJie20190102 commented on pull request #13683: [Fix-13596][Task Instance] Throw an error message to tell the user th…
Posted by "LiJie20190102 (via GitHub)" <gi...@apache.org>.
LiJie20190102 commented on PR #13683:
URL: https://github.com/apache/dolphinscheduler/pull/13683#issuecomment-1457569265
@caishunfeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Radeity commented on pull request #13683: [Fix-13596][Task Instance] Throw an error message to tell the user th…
Posted by "Radeity (via GitHub)" <gi...@apache.org>.
Radeity commented on PR #13683:
URL: https://github.com/apache/dolphinscheduler/pull/13683#issuecomment-1459448368
Hi, @LiJie20190102 , i suggest you post your original issue (https://github.com/apache/dolphinscheduler/issues/13656) to describe clearly which bug do you fix in this pr, cuz i just find that this pr doesn't fix the same NPE error mentioned in https://github.com/apache/dolphinscheduler/issues/13583.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] LiJie20190102 commented on a diff in pull request #13683: [Fix-13596][Task Instance] Throw an error message to tell the user th…
Posted by "LiJie20190102 (via GitHub)" <gi...@apache.org>.
LiJie20190102 commented on code in PR #13683:
URL: https://github.com/apache/dolphinscheduler/pull/13683#discussion_r1155685463
##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java:
##########
@@ -1810,6 +1808,10 @@ private ResourceInfo updateResourceInfo(ResourceInfo res) {
resourceInfo = new ResourceInfo();
// get resource from database, only one resource should be returned
Resource resource = getResourceById(resourceId);
+ if (Objects.isNull(resource)) {
+ logger.error("resource not found, resourceId: {}", resourceId);
+ return null;
Review Comment:
> can we directly throw the exception here?
I don't think this is feasible because if an exception is thrown here, there will be a failed queue that will retry the task indefinitely, causing the error log to refresh the screen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #13683: [Fix-13596][Task Instance] Throw an error message to tell the user th…
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #13683:
URL: https://github.com/apache/dolphinscheduler/pull/13683#issuecomment-1463550323
## [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/13683?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`3.1.5-prepare@d2b0b34`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head f4d6fb7 differs from pull request most recent head 106bc87. Consider uploading reports for the commit 106bc87 to get more accurate results
```diff
@@ Coverage Diff @@
## 3.1.5-prepare #13683 +/- ##
================================================
Coverage ? 38.12%
Complexity ? 3958
================================================
Files ? 998
Lines ? 36799
Branches ? 4245
================================================
Hits ? 14030
Misses ? 21155
Partials ? 1614
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #13683: [Fix-13596][Task Instance] Throw an error message to tell the user th…
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #13683:
URL: https://github.com/apache/dolphinscheduler/pull/13683#issuecomment-1489907154
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=13683)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=VULNERABILITY) [7 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=CODE_SMELL) [669 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13683&metric=new_coverage&view=list) [29.4% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13683&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13683&metric=new_duplicated_lines_density&view=list) [1.2% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13683&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #13683: [Fix-13596][Task Instance] Throw an error message to tell the user th…
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #13683:
URL: https://github.com/apache/dolphinscheduler/pull/13683#issuecomment-1489917213
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=13683)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=VULNERABILITY) [7 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=CODE_SMELL) [669 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13683&metric=new_coverage&view=list) [29.4% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13683&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13683&metric=new_duplicated_lines_density&view=list) [1.2% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13683&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on pull request #13683: [Fix-13596][Task Instance] Throw an error message to tell the user th…
Posted by "fuchanghai (via GitHub)" <gi...@apache.org>.
fuchanghai commented on PR #13683:
URL: https://github.com/apache/dolphinscheduler/pull/13683#issuecomment-1457442710
@SbloodyS @caishunfeng Whether #13678 should be associated with it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] LiJie20190102 commented on pull request #13683: [Fix-13596][Task Instance] Throw an error message to tell the user th…
Posted by "LiJie20190102 (via GitHub)" <gi...@apache.org>.
LiJie20190102 commented on PR #13683:
URL: https://github.com/apache/dolphinscheduler/pull/13683#issuecomment-1460340250
> Hi, @LiJie20190102 , i suggest you post your original issue (#13656) to describe clearly which bug do you fix in this pr, cuz i just find that this pr doesn't fix the same NPE error mentioned in #13583.
I can solve NPE by following the “How to reproduce” steps in #13583 . Is there a problem with your test steps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #13683: [Fix-13596][Task Instance] Throw an error message to tell the user th…
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #13683:
URL: https://github.com/apache/dolphinscheduler/pull/13683#issuecomment-1463560827
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=13683)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=VULNERABILITY) [7 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=CODE_SMELL) [657 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13683&metric=new_coverage&view=list) [30.2% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13683&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13683&metric=new_duplicated_lines_density&view=list) [1.3% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13683&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #13683: [Fix-13596][Task Instance] Throw an error message to tell the user th…
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #13683:
URL: https://github.com/apache/dolphinscheduler/pull/13683#issuecomment-1463562063
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=13683)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=VULNERABILITY) [7 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=CODE_SMELL) [657 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13683&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13683&metric=new_coverage&view=list) [30.2% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13683&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13683&metric=new_duplicated_lines_density&view=list) [1.3% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13683&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Radeity commented on pull request #13683: [Fix-13596][Task Instance] Throw an error message to tell the user th…
Posted by "Radeity (via GitHub)" <gi...@apache.org>.
Radeity commented on PR #13683:
URL: https://github.com/apache/dolphinscheduler/pull/13683#issuecomment-1460488600
> I can solve NPE by following the “How to reproduce” steps in #13583 . Is there a problem with your test steps? What are your detailed test steps. 
I haven't tried to reproduce it, anyway, glad to hear that this pr can solve that problem, thx : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] LiJie20190102 commented on pull request #13683: [Fix-13596][Task Instance] Throw an error message to tell the user th…
Posted by "LiJie20190102 (via GitHub)" <gi...@apache.org>.
LiJie20190102 commented on PR #13683:
URL: https://github.com/apache/dolphinscheduler/pull/13683#issuecomment-1474730423
> @SbloodyS @caishunfeng @Radeity I only modified one file. Should I deal with these code
>
> 
@SbloodyS @caishunfeng @Radeity Have you seen my news? Please help me. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org