Re: [PR] Cases API + 4 implementations (Pascal, Camel, Kebab, Snake) [commons-text]

["theshoeshiner (via GitHub)" <gi...@apache.org>]

theshoeshiner commented on code in PR #450:
URL: https://github.com/apache/commons-text/pull/450#discussion_r1366855930


##########
src/main/java/org/apache/commons/text/cases/CamelCase.java:
##########
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.text.cases;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.commons.lang3.CharUtils;
+import org.apache.commons.lang3.StringUtils;
+
+/**
+ * Case implementation that parses and formats strings of the form 'myCamelCase'
+ * <p>
+ * This case separates tokens on uppercase ASCII alpha characters. Each token begins with an

Review Comment:
   I updated the Camel/Pascal case classes significantly to rely on the [unicode case cateogry](https://www.unicode.org/L2/L1999/UnicodeData.html#General%20Category). 
   
   Any character that needs to be converted to a upper / lower case must convert precisely to that case (as implemented by `Character.isUpperCase` and `Character.isLowerCase`). This is worth noting because a few unicode characters have upper case mappings point to a title case character which has no clear lower case mapping, and thus cannot be deterministically converted back to lower case (without some sort of user configuration).
   
   Updated test cases accordingly to include digraph character and title case character tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org