You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/12/03 06:31:48 UTC

[GitHub] [iceberg] jshmchenxi opened a new issue #1865: Add support for building runtime jars containing the sources

jshmchenxi opened a new issue #1865:
URL: https://github.com/apache/iceberg/issues/1865


   It will be easier to debug locally if the runtime jars (eg. iceberg-flink-runtime/iceberg-spark-runtime) contain sources.
   Just like the [flink-shaded](https://github.com/apache/flink-shaded) project, it supports command `mvn package -Dshade-sources` to build source jar for shaded resources.
   I'm new to gradle and currently have no idea how to achieve this.
   It will be appreciated if anyone could help.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] openinx commented on issue #1865: Add support for building runtime jars containing the sources

Posted by GitBox <gi...@apache.org>.
openinx commented on issue #1865:
URL: https://github.com/apache/iceberg/issues/1865#issuecomment-737721603


   The published `iceberg-flink-runtime` should not contains sources code, because it's for production purpose.  If you really want to debug the runtime code, you might need to rebuild the project to get a new runtime jar with sources attached.  For most cases, I don't use the IDE debug directly,  I will read the stactrace and read the code base to see what's wong, if it indeed a potential bug, I will write an unit test to reproduce.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] pan3793 commented on issue #1865: Add support for building runtime jars containing the sources

Posted by GitBox <gi...@apache.org>.
pan3793 commented on issue #1865:
URL: https://github.com/apache/iceberg/issues/1865#issuecomment-739450062


   Also +1 for attaching `shade-sources`.
   We use `iceberg-*-runtime` directly in `pom.xml` to avoid conflicting with exist cdh6 dependencies. For example, cdh6 use `hive-2.1.1` which bundled `hive-orc` instead of `apache-orc`, but with same package path, the new `apache-orc` will break the build.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org