You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/15 18:40:26 UTC
[GitHub] [airflow] ryanahamilton opened a new pull request #11559: Auto-refresh default state
ryanahamilton opened a new pull request #11559:
URL: https://github.com/apache/airflow/pull/11559
Follow-up to the auto-refresh feature just added in #11534. This defaults the auto-refresh switch to an "off" state if the DAG does not have `RUNNING` DAG runs.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on a change in pull request #11559: Auto-refresh default state
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on a change in pull request #11559:
URL: https://github.com/apache/airflow/pull/11559#discussion_r505872927
##########
File path: airflow/www/views.py
##########
@@ -1842,7 +1847,8 @@ class GraphForm(DateTimeWithNumRunsWithDagRunsForm):
nodes=nodes,
edges=edges,
show_external_log_redirect=task_log_reader.supports_external_link,
- external_log_name=external_log_name)
+ external_log_name=external_log_name,
Review comment:
Fixed, thanks @kaxil!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #11559: Auto-refresh default state
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #11559:
URL: https://github.com/apache/airflow/pull/11559#discussion_r505772426
##########
File path: airflow/www/views.py
##########
@@ -1842,7 +1847,8 @@ class GraphForm(DateTimeWithNumRunsWithDagRunsForm):
nodes=nodes,
edges=edges,
show_external_log_redirect=task_log_reader.supports_external_link,
- external_log_name=external_log_name)
+ external_log_name=external_log_name,
Review comment:
I was mostly thinking of the current DagRun i.e. if this DagRun isn't running we don't refresh as with the current change, if another DagRun is running, this will still refresh automatically
You can get the state of it already using `dt_nr_dr_data['dr_state']` (also used on L1839)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #11559: Auto-refresh default state
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #11559:
URL: https://github.com/apache/airflow/pull/11559#discussion_r505772426
##########
File path: airflow/www/views.py
##########
@@ -1842,7 +1847,8 @@ class GraphForm(DateTimeWithNumRunsWithDagRunsForm):
nodes=nodes,
edges=edges,
show_external_log_redirect=task_log_reader.supports_external_link,
- external_log_name=external_log_name)
+ external_log_name=external_log_name,
Review comment:
I was mostly thinking of the current DagRun.
You can get the state of it already using `dt_nr_dr_data['dr_state']` (also used on L1839)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #11559: Auto-refresh default state
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #11559:
URL: https://github.com/apache/airflow/pull/11559
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org