[jira] [Comment Edited] (SOLR-5114) stop tracking IndexCommit in replication handler

["Yonik Seeley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-5114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13731453#comment-13731453 ] 

Yonik Seeley edited comment on SOLR-5114 at 8/6/13 11:51 PM:
-------------------------------------------------------------

Mostly working snapshot patch.
Trying to figure out what the current behavior is supposed to be in many different scenarios is difficult.  One test fails: testEmptyCommits...

edit: oh, this patch also removes a race condition between getting an index commit and reserving it.
                
      was (Author: yseeley@gmail.com):
    Mostly working snapshot patch.
Trying to figure out what the current behavior is supposed to be in many different scenarios is difficult.  One test fails: testEmptyCommits...
                  
> stop tracking IndexCommit in replication handler
> ------------------------------------------------
>
>                 Key: SOLR-5114
>                 URL: https://issues.apache.org/jira/browse/SOLR-5114
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Yonik Seeley
>            Priority: Trivial
>         Attachments: SOLR-5114.patch
>
>
> It seems like indexCommitPoint tries to track the latest index commit.  This doesn't seem necessary and could lead to bugs if it's not tracked correctly.  We should always be able to ask the deletion policy for the latest commit (including a fallback mechanism if no IW has yet been opened)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org