You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2020/08/28 00:02:31 UTC

[GitHub] [groovy] eric-milles commented on pull request #1356: GROOVY-9702: make ASTTest value optional (from a JDK bytecode perspec…

eric-milles commented on pull request #1356:
URL: https://github.com/apache/groovy/pull/1356#issuecomment-682250429


   @paulk-asert What is the breaking change?  I'm doubtful anyone relies on runtime retention since the implementation is to read the closure literal's source text and execute that as a script.  You can't even add the arrow to the closure expression without it failing.  There is nothing about the compiled result that is used by ASTTestTransformation.  Only if someone used the ASTTest annotation afterwards for some other purpose would this be a breaking change.
   
   It is okay not to merge back into earlier Groovy versions if you are at all concerned.  This particular change would stop the IDE from giving a warning if you fail to supply a closure, so I don't think it is desirable.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org