You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2016/02/24 00:15:53 UTC
Review Request 43915: Introduced the
`--cgroups_net_cls_secondary_handles` flag in the agent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43915/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Introduced the `--cgroups_net_cls_secondary_handles` flag in the agent.
Diffs
-----
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp f05cd55a9e080f44566ec7dcef22f11950496d6f
src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61
src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a
Diff: https://reviews.apache.org/r/43915/diff/
Testing
-------
make and make check
Thanks,
Avinash sridharan
Re: Review Request 43915: Introduced the
`--cgroups_net_cls_secondary_handles` flag in the agent.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43915/
-----------------------------------------------------------
(Updated March 1, 2016, 10:17 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-4700
https://issues.apache.org/jira/browse/MESOS-4700
Repository: mesos
Description
-------
Introduced the `--cgroups_net_cls_secondary_handles` flag in the agent.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp f05cd55a9e080f44566ec7dcef22f11950496d6f
src/slave/flags.hpp c07932157ffe36ea36f1def4c7d92b79d2219c48
src/slave/flags.cpp 7f139e99e8392fe95bb30070896ed9d95dfe5701
Diff: https://reviews.apache.org/r/43915/diff/
Testing
-------
make and make check
Thanks,
Avinash sridharan
Re: Review Request 43915: Introduced the
`--cgroups_net_cls_secondary_handles` flag in the agent.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43915/
-----------------------------------------------------------
(Updated March 1, 2016, 7:59 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-4700
https://issues.apache.org/jira/browse/MESOS-4700
Repository: mesos
Description
-------
Introduced the `--cgroups_net_cls_secondary_handles` flag in the agent.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp f05cd55a9e080f44566ec7dcef22f11950496d6f
src/slave/flags.hpp c07932157ffe36ea36f1def4c7d92b79d2219c48
src/slave/flags.cpp 7f139e99e8392fe95bb30070896ed9d95dfe5701
Diff: https://reviews.apache.org/r/43915/diff/
Testing
-------
make and make check
Thanks,
Avinash sridharan
Re: Review Request 43915: Introduced the
`--cgroups_net_cls_secondary_handles` flag in the agent.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43915/
-----------------------------------------------------------
(Updated March 1, 2016, 7:56 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Addressed reviews.
Bugs: MESOS-4700
https://issues.apache.org/jira/browse/MESOS-4700
Repository: mesos
Description
-------
Introduced the `--cgroups_net_cls_secondary_handles` flag in the agent.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp f05cd55a9e080f44566ec7dcef22f11950496d6f
src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61
src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a
Diff: https://reviews.apache.org/r/43915/diff/
Testing
-------
make and make check
Thanks,
Avinash sridharan
Re: Review Request 43915: Introduced the
`--cgroups_net_cls_secondary_handles` flag in the agent.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43915/#review121447
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (line 313)
<https://reviews.apache.org/r/43915/#comment183151>
Please use explicit check here:
```
if (lower.get() == 0)
```
- Jie Yu
On Feb. 29, 2016, 10:16 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43915/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 10:16 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4700
> https://issues.apache.org/jira/browse/MESOS-4700
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Introduced the `--cgroups_net_cls_secondary_handles` flag in the agent.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp f05cd55a9e080f44566ec7dcef22f11950496d6f
> src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61
> src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a
>
> Diff: https://reviews.apache.org/r/43915/diff/
>
>
> Testing
> -------
>
> make and make check
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 43915: Introduced the
`--cgroups_net_cls_secondary_handles` flag in the agent.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43915/
-----------------------------------------------------------
(Updated Feb. 29, 2016, 10:16 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Changed patch dependency.
Bugs: MESOS-4700
https://issues.apache.org/jira/browse/MESOS-4700
Repository: mesos
Description
-------
Introduced the `--cgroups_net_cls_secondary_handles` flag in the agent.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp f05cd55a9e080f44566ec7dcef22f11950496d6f
src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61
src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a
Diff: https://reviews.apache.org/r/43915/diff/
Testing
-------
make and make check
Thanks,
Avinash sridharan
Re: Review Request 43915: Introduced the
`--cgroups_net_cls_secondary_handles` flag in the agent.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43915/
-----------------------------------------------------------
(Updated Feb. 24, 2016, 4:45 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4700
https://issues.apache.org/jira/browse/MESOS-4700
Repository: mesos
Description
-------
Introduced the `--cgroups_net_cls_secondary_handles` flag in the agent.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp f05cd55a9e080f44566ec7dcef22f11950496d6f
src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61
src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a
Diff: https://reviews.apache.org/r/43915/diff/
Testing
-------
make and make check
Thanks,
Avinash sridharan
Re: Review Request 43915: Introduced the
`--cgroups_net_cls_secondary_handles` flag in the agent.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43915/
-----------------------------------------------------------
(Updated Feb. 23, 2016, 11:21 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Added JIRA.
Bugs: MESOS-4700
https://issues.apache.org/jira/browse/MESOS-4700
Repository: mesos
Description
-------
Introduced the `--cgroups_net_cls_secondary_handles` flag in the agent.
Diffs
-----
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp f05cd55a9e080f44566ec7dcef22f11950496d6f
src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61
src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a
Diff: https://reviews.apache.org/r/43915/diff/
Testing
-------
make and make check
Thanks,
Avinash sridharan