You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/02/12 19:37:18 UTC

[GitHub] [maven-indexer] cstamas opened a new pull request #178: Fix Spring example

cstamas opened a new pull request #178:
URL: https://github.com/apache/maven-indexer/pull/178


   Seems Spring example contained a typo since beginning:
   it uses "/" (slash) in context ID.
   
   Still, it worked before but not since commit
   019edb7ff87a505372ad4f469c1b2a6c9d4ae292 as
   Files.createTempDirectory fails if prefix contains
   path separator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-indexer] cstamas commented on pull request #178: Fix Spring example

Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #178:
URL: https://github.com/apache/maven-indexer/pull/178#issuecomment-1037493091


   @carlspring FYI, I did not add validation and after 2nd commit slash will still work (as method will not be double-invoked, once with `null` and once with actual directory), but in general slash should not be used in ID (unsure was this a typo or you use it like this).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-indexer] carlspring commented on pull request #178: [MINDEXER-140] Fix double invocation of DefaultIndexingContext.setIndexDirectoryFile

Posted by GitBox <gi...@apache.org>.
carlspring commented on pull request #178:
URL: https://github.com/apache/maven-indexer/pull/178#issuecomment-1038550746


   @cstamas : Thanks for the clarification! I believe thie was introduced due to my misunderstanding of how it should work.
   
   It would really help if there is a detailed page with examples on how to use the Maven Indexer. It's great to have example code, but if you'd like more people to understand this, there ought to also be some more thorough documentation. As this project has not been touched in many years and since there have been quite a few changes, I think that now would be a great time to add such documentation. It would also be great, if it could come from someone like yourself, who has worked a long time on this project and knows all the intricacies and peculiarities.
   
   On a different topic, it would probably also be great, if any remaing code that refers to Nexus could be removed in order to avoid confusion, (if I recall correctly, there were classes such as `NexusIndexer`, etc., forgive me, I have not dug around the code in years). As far as I recall, this is a generic implementation that is unrelated to Nexus itself, right?
   
   Thanks for your hard work on pushing the `maven-indexer` forward! :)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-indexer] cstamas commented on pull request #178: Fix Spring example

Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #178:
URL: https://github.com/apache/maven-indexer/pull/178#issuecomment-1037493091


   @carlspring FYI, I did not add validation and after 2nd commit slash will still work (as method will not be double-invoked, once with `null` and once with actual directory), but in general slash should not be used in ID (unsure was this a typo or you use it like this).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-indexer] cstamas merged pull request #178: [MINDEXER-140] Fix double invocation of DefaultIndexingContext.setIndexDirectoryFile

Posted by GitBox <gi...@apache.org>.
cstamas merged pull request #178:
URL: https://github.com/apache/maven-indexer/pull/178


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-indexer] carlspring commented on pull request #178: [MINDEXER-140] Fix double invocation of DefaultIndexingContext.setIndexDirectoryFile

Posted by GitBox <gi...@apache.org>.
carlspring commented on pull request #178:
URL: https://github.com/apache/maven-indexer/pull/178#issuecomment-1038550746


   @cstamas : Thanks for the clarification! I believe thie was introduced due to my misunderstanding of how it should work.
   
   It would really help if there is a detailed page with examples on how to use the Maven Indexer. It's great to have example code, but if you'd like more people to understand this, there ought to also be some more thorough documentation. As this project has not been touched in many years and since there have been quite a few changes, I think that now would be a great time to add such documentation. It would also be great, if it could come from someone like yourself, who has worked a long time on this project and knows all the intricacies and peculiarities.
   
   On a different topic, it would probably also be great, if any remaing code that refers to Nexus could be removed in order to avoid confusion, (if I recall correctly, there were classes such as `NexusIndexer`, etc., forgive me, I have not dug around the code in years). As far as I recall, this is a generic implementation that is unrelated to Nexus itself, right?
   
   Thanks for your hard work on pushing the `maven-indexer` forward! :)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org