[GitHub] [pinot] navina commented on a diff in pull request #10216: Allow segment upload to deepstore only when server segment store uri is configured

["navina (via GitHub)" <gi...@apache.org>]

navina commented on code in PR #10216:
URL: https://github.com/apache/pinot/pull/10216#discussion_r1096255028


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentCommitterFactory.java:
##########
@@ -69,9 +70,13 @@ public SegmentCommitter createSegmentCommitter(boolean isSplitCommit, SegmentCom
 
     boolean uploadToFs = _streamConfig.isServerUploadToDeepStore();
     String peerSegmentDownloadScheme = _tableConfig.getValidationConfig().getPeerSegmentDownloadScheme();
-    // TODO: exists for backwards compatibility. remove peerDownloadScheme non-null check once users have migrated
-    if (uploadToFs || peerSegmentDownloadScheme != null) {
-      segmentUploader = new PinotFSSegmentUploader(_indexLoadingConfig.getSegmentStoreURI(),
+    String segmentStoreUri = _indexLoadingConfig.getSegmentStoreURI();
+
+    // We seem to allow the server instance to come up without a valid segment store uri. Hence, this check is needed.
+    if (!Strings.isNullOrEmpty(segmentStoreUri)

Review Comment:
   Fixed based on our offline discussion. Modified to not default to controller upload. Instead added config validation before table data manager is created. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org