You are viewing a plain text version of this content. The canonical link for it is here.
Posted to builds@geaflow.apache.org by GitBox <gi...@apache.org> on 2026/02/18 04:46:45 UTC

[GH] (geaflow/master): Workflow run "npm_and_yarn in /geaflow/geaflow-dashboard/web-dashboard for ajv - Update #1247687900" failed!

The GitHub Actions job "npm_and_yarn in /geaflow/geaflow-dashboard/web-dashboard for ajv - Update #1247687900" on geaflow.git/master has failed.
Run started by GitHub user dependabot[bot] (triggered by dependabot[bot]).

Head commit for run:
38dabca238cff216893999eb95ecd53ba9457199 / Weichen Zhao <61...@users.noreply.github.com>
feat: implement ISO-GQL SAME predicate for element identity compariso… (#692)

* feat: implement ISO-GQL SAME predicate for element identity comparison (#368)

Implement the ISO-GQL SAME predicate function to check if graph elements
refer to the same entity by comparing their identities. This feature adds
full ISO/IEC 39075:2024 Section 19.12 compliance for identity comparisons.

Changes:
- Parser Layer:
  * Add SqlSameCall AST node for SAME function calls
  * Add SqlSameOperator with BOOLEAN return type and VARIADIC operands
  * Register operator in BuildInSqlOperatorTable
  * Add syntax tests with 4 GQL test cases

- Runtime Layer:
  * Implement GeaFlowBuiltinFunctions.same() for identity comparison
    - Vertex comparison: compares vertex IDs using Objects.equals()
    - Edge comparison: compares both source and target IDs
    - Null handling: returns null following SQL ternary logic
    - Type safety: returns false for mismatched types
  * Add BuildInExpression.SAME constant for expression translation
  * Register SAME in ExpressionTranslator.processOtherTrans()

- Testing:
  * Add comprehensive SameTest with 13 unit tests (100% pass rate)
  * Test coverage: identical/different IDs, null handling, mixed types,
    string IDs, invalid types

Implementation follows Approach 1 (Built-in Function Pattern) with
minimal code changes (441 lines added across 9 files) for maximum
simplicity and maintainability.

Example usage:
  MATCH (a)->(b)->(c) WHERE SAME(a, c) RETURN a, b, c;

* fix(dsl): resolve ISO-GQL SAME predicate code review issues

- Fix SqlSameCall immutable operands list causing setOperand() failure
- Add type-specific same() overloads for RowVertex and RowEdge
- Add varargs same(Object...) for multi-element comparisons
- Add comprehensive unit tests for all same() overloads

Report URL: https://github.com/apache/geaflow/actions/runs/22126923845

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: builds-unsubscribe@geaflow.apache.org
For additional commands, e-mail: builds-help@geaflow.apache.org