[GitHub] [iceberg] gaborkaszab commented on a diff in pull request #5772: Core: Deprecate functions in TableMetadata and DataWriter

[GitBox <gi...@apache.org>]

gaborkaszab commented on code in PR #5772:
URL: https://github.com/apache/iceberg/pull/5772#discussion_r983695852


##########
data/src/test/java/org/apache/iceberg/io/TestWriterMetrics.java:
##########
@@ -287,10 +287,10 @@ public void testMaxColumnsWithDefaultOverride() throws IOException {
         OutputFileFactory.builderFor(maxColumnTable, 1, 1).format(fileFormat).build();
 
     T row = toGenericRow(1, numColumns);
-    DataWriter dataWriter =
+    DataWriter<T> dataWriter =

Review Comment:
   I think the reason it is written like this is that `DataFile dataFile = dataWriter.toDataFile();` below has to be called when dataWriter is closed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org