You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/12/10 02:27:58 UTC
Re: Review Request 39219: Windows: Added support for
`slave/state.cpp`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39219/
-----------------------------------------------------------
(Updated Dec. 10, 2015, 1:27 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3615
https://issues.apache.org/jira/browse/MESOS-3615
Repository: mesos
Description
-------
Windows: Added support for `slave/state.cpp`.
Diffs
-----
src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
src/slave/state.cpp d14159f5e8ca9957cbdcce53050b00a00dba2135
Diff: https://reviews.apache.org/r/39219/diff/
Testing
-------
Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
Re: Review Request 39219: Windows: Added support for
`slave/state.cpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Dec. 10, 2015, 1:37 a.m., Joris Van Remoortere wrote:
> > src/slave/state.cpp, lines 39-43
> > <https://reviews.apache.org/r/39219/diff/6/?file=1125974#file1125974line39>
> >
> > what about `<stout/os/close.hpp>`?
You committed it already, so, uh, well, I guess we'll get it next time.
#ThanksForPaddingMyNumberOfCommits
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39219/#review109654
-----------------------------------------------------------
On Dec. 10, 2015, 1:27 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39219/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 1:27 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3615
> https://issues.apache.org/jira/browse/MESOS-3615
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added support for `slave/state.cpp`.
>
>
> Diffs
> -----
>
> src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
> src/slave/state.cpp d14159f5e8ca9957cbdcce53050b00a00dba2135
>
> Diff: https://reviews.apache.org/r/39219/diff/
>
>
> Testing
> -------
>
> Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39219: Windows: Added support for
`slave/state.cpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Dec. 10, 2015, 1:37 a.m., Joris Van Remoortere wrote:
> > src/slave/state.cpp, lines 39-43
> > <https://reviews.apache.org/r/39219/diff/6/?file=1125974#file1125974line39>
> >
> > what about `<stout/os/close.hpp>`?
>
> Alex Clemmer wrote:
> You committed it already, so, uh, well, I guess we'll get it next time.
>
> #ThanksForPaddingMyNumberOfCommits
Ooops. #WhenYourHashtagsGetInterpretedAsMarkdownHeaders
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39219/#review109654
-----------------------------------------------------------
On Dec. 10, 2015, 1:27 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39219/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 1:27 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3615
> https://issues.apache.org/jira/browse/MESOS-3615
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added support for `slave/state.cpp`.
>
>
> Diffs
> -----
>
> src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
> src/slave/state.cpp d14159f5e8ca9957cbdcce53050b00a00dba2135
>
> Diff: https://reviews.apache.org/r/39219/diff/
>
>
> Testing
> -------
>
> Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39219: Windows: Added support for
`slave/state.cpp`.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39219/#review109654
-----------------------------------------------------------
Ship it!
src/slave/state.cpp (lines 36 - 40)
<https://reviews.apache.org/r/39219/#comment169249>
what about `<stout/os/close.hpp>`?
- Joris Van Remoortere
On Dec. 10, 2015, 1:27 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39219/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 1:27 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3615
> https://issues.apache.org/jira/browse/MESOS-3615
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added support for `slave/state.cpp`.
>
>
> Diffs
> -----
>
> src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
> src/slave/state.cpp d14159f5e8ca9957cbdcce53050b00a00dba2135
>
> Diff: https://reviews.apache.org/r/39219/diff/
>
>
> Testing
> -------
>
> Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
>
>
> Thanks,
>
> Alex Clemmer
>
>