You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jakarta.apache.org by bu...@apache.org on 2011/09/20 00:27:59 UTC

DO NOT REPLY [Bug 51847] New: [PATCH] Some Junit tests are Locale sensitive and fail if Locale is different from US

https://issues.apache.org/bugzilla/show_bug.cgi?id=51847

             Bug #: 51847
           Summary: [PATCH] Some Junit tests are Locale sensitive and fail
                    if Locale is different from US
           Product: JMeter
           Version: 2.5
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Main
        AssignedTo: notifications@jakarta.apache.org
        ReportedBy: benoit.wiart@gmail.com
    Classification: Unclassified


Created attachment 27539
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27539
Fix the bug

Date format in org.apache.jmeter.protocol.http.control.TestCacheManager depends
on the jvm default locale.

The patch reuse the httpclient dateutil to format the dates, it's already used
for parsing.

Benoit WIART

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org


DO NOT REPLY [Bug 51847] [PATCH] Some Junit tests are Locale sensitive and fail if Locale is different from US

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51847

--- Comment #3 from Philippe Mouawad <p....@ubik-ingenierie.com> 2011-09-20 08:21:11 UTC ---
Hello,
I confirm these failures in French Locale.
Fix works for me.

Regards
Philippe

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org


DO NOT REPLY [Bug 51847] [PATCH] Some Junit tests are Locale sensitive and fail if Locale is different from US

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51847

Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #1 from Sebb <se...@apache.org> 2011-09-19 23:13:46 UTC ---
What Locale does it fail on?

I don't use Locale.US and I've not seen any failures.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org


DO NOT REPLY [Bug 51847] [PATCH] Some Junit tests are Locale sensitive and fail if Locale is different from US

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51847

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org


DO NOT REPLY [Bug 51847] [PATCH] Some Junit tests are Locale sensitive and fail if Locale is different from US

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51847

--- Comment #4 from Sebb <se...@apache.org> 2011-09-20 09:21:40 UTC ---
Thanks for the report and patch.

I was using an English Locale, which is why I did not see the problem.

Fixed, but without using DateUtil.

URL: http://svn.apache.org/viewvc?rev=1173042&view=rev
Log:
Bug 51847 - Some Junit tests are Locale sensitive and fail if Locale is
different from US

Modified:
  
jakarta/jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestCacheManager.java
   jakarta/jmeter/trunk/xdocs/changes.xml

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org


DO NOT REPLY [Bug 51847] [PATCH] Some Junit tests are Locale sensitive and fail if Locale is different from US

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51847

benoit.wiart@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW

--- Comment #2 from benoit.wiart@gmail.com 2011-09-20 06:43:43 UTC ---
It should also work with other english languages not only US

Expires date is formatted with the jvm default locale (in makeDate) but is
parsed with Locale.US in DateUtil in CacheManager
the expires date should follow rfc 1123

For example with Locale fr_FR
Expires is mar., 20 sept. 2011 06:39:16 GMT
Where it should be Tue, 20 Sep 2011 06:39:16 GMT

Below are the failures

1)
testExpiresJava(org.apache.jmeter.protocol.http.control.TestCacheManager)junit.framework.AssertionFailedError:
Should find valid entry
     [java]     at
org.apache.jmeter.protocol.http.control.TestCacheManager.testExpiresJava(TestCacheManager.java:191)
     [java]     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [java]     at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
     [java]     at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
     [java]     at org.apache.jorphan.test.AllTests.main(AllTests.java:233)
     [java] 2)
testExpiresHttpClient(org.apache.jmeter.protocol.http.control.TestCacheManager)junit.framework.AssertionFailedError:
Should find valid entry
     [java]     at
org.apache.jmeter.protocol.http.control.TestCacheManager.testExpiresHttpClient(TestCacheManager.java:213)
     [java]     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [java]     at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
     [java]     at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
     [java]     at org.apache.jorphan.test.AllTests.main(AllTests.java:233)
     [java] FAILURES!!!

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org