[jira] [Commented] (HDFS-7434) DatanodeID hashCode should not be mutable

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-7434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347546#comment-14347546 ] 

Hadoop QA commented on HDFS-7434:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12702505/HDFS-7434.patch
  against trunk revision 3560180.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9733//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9733//console

This message is automatically generated.

> DatanodeID hashCode should not be mutable
> -----------------------------------------
>
>                 Key: HDFS-7434
>                 URL: https://issues.apache.org/jira/browse/HDFS-7434
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HDFS-7434.patch
>
>
> Mutable hash codes may lead to orphaned instances in a collection.  Instances must always be removed prior to modification of hash code values, and re-inserted.  Although current code appears to do this, the mutable hash code is a landmine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)