You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/04/04 23:54:03 UTC
Review Request 20052: Replace CHECK with Failure for exec in
MesosContainerizer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20052/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Tobi Knaup, and Vinod Kone.
Bugs: MESOS-1193
https://issues.apache.org/jira/browse/MESOS-1193
Repository: mesos-git
Description
-------
Replace CHECK with Failure for exec in MesosContainerizer
Diffs
-----
src/slave/containerizer/mesos_containerizer.cpp c819c97d96d232a1de3c1ed2fc848bebf66981f7
Diff: https://reviews.apache.org/r/20052/diff/
Testing
-------
none
Thanks,
Ian Downes
Re: Review Request 20052: Replace CHECK with Failure for exec in
MesosContainerizer
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20052/#review39970
-----------------------------------------------------------
Ship it!
Ship it modulo adding a comment per benh.
- Vinod Kone
On April 4, 2014, 9:54 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20052/
> -----------------------------------------------------------
>
> (Updated April 4, 2014, 9:54 p.m.)
>
>
> Review request for mesos, Ben Mahler, Tobi Knaup, and Vinod Kone.
>
>
> Bugs: MESOS-1193
> https://issues.apache.org/jira/browse/MESOS-1193
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Replace CHECK with Failure for exec in MesosContainerizer
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos_containerizer.cpp c819c97d96d232a1de3c1ed2fc848bebf66981f7
>
> Diff: https://reviews.apache.org/r/20052/diff/
>
>
> Testing
> -------
>
> none
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20052: Replace CHECK with Failure for exec in
MesosContainerizer
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20052/#review39603
-----------------------------------------------------------
Patch looks great!
Reviews applied: [20052]
All tests passed.
- Mesos ReviewBot
On April 4, 2014, 9:54 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20052/
> -----------------------------------------------------------
>
> (Updated April 4, 2014, 9:54 p.m.)
>
>
> Review request for mesos, Ben Mahler, Tobi Knaup, and Vinod Kone.
>
>
> Bugs: MESOS-1193
> https://issues.apache.org/jira/browse/MESOS-1193
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Replace CHECK with Failure for exec in MesosContainerizer
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos_containerizer.cpp c819c97d96d232a1de3c1ed2fc848bebf66981f7
>
> Diff: https://reviews.apache.org/r/20052/diff/
>
>
> Testing
> -------
>
> none
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20052: Replace CHECK with Failure for exec in
MesosContainerizer
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20052/#review39657
-----------------------------------------------------------
Ship it!
src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/20052/#comment72222>
I guess this is possible if a destroy occurred while the launch was happening? Is it worth a brief comment above? Also, are there other places that are susceptible?
- Benjamin Hindman
On April 4, 2014, 9:54 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20052/
> -----------------------------------------------------------
>
> (Updated April 4, 2014, 9:54 p.m.)
>
>
> Review request for mesos, Ben Mahler, Tobi Knaup, and Vinod Kone.
>
>
> Bugs: MESOS-1193
> https://issues.apache.org/jira/browse/MESOS-1193
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Replace CHECK with Failure for exec in MesosContainerizer
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos_containerizer.cpp c819c97d96d232a1de3c1ed2fc848bebf66981f7
>
> Diff: https://reviews.apache.org/r/20052/diff/
>
>
> Testing
> -------
>
> none
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20052: Replace CHECK with Failure for exec in
MesosContainerizer
Posted by Tobi Knaup <to...@knaup.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20052/#review39644
-----------------------------------------------------------
Ship it!
lgtm as a quick fix.
- Tobi Knaup
On April 4, 2014, 9:54 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20052/
> -----------------------------------------------------------
>
> (Updated April 4, 2014, 9:54 p.m.)
>
>
> Review request for mesos, Ben Mahler, Tobi Knaup, and Vinod Kone.
>
>
> Bugs: MESOS-1193
> https://issues.apache.org/jira/browse/MESOS-1193
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Replace CHECK with Failure for exec in MesosContainerizer
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos_containerizer.cpp c819c97d96d232a1de3c1ed2fc848bebf66981f7
>
> Diff: https://reviews.apache.org/r/20052/diff/
>
>
> Testing
> -------
>
> none
>
>
> Thanks,
>
> Ian Downes
>
>