You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Remko Popma <re...@gmail.com> on 2014/10/05 03:58:41 UTC
Re: [1/3] git commit: Use of constants in JConsole plugin.
Thanks!
On Sun, Oct 5, 2014 at 10:58 AM, Remko Popma <re...@gmail.com> wrote:
> Thanks!
>
> On Sun, Oct 5, 2014 at 8:55 AM, <ma...@apache.org> wrote:
>
>> Repository: logging-log4j2
>> Updated Branches:
>> refs/heads/master 5ae0e6c00 -> 85f586c99
>>
>>
>> Use of constants in JConsole plugin.
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
>> Commit:
>> http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/1ebbf54b
>> Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/1ebbf54b
>> Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/1ebbf54b
>>
>> Branch: refs/heads/master
>> Commit: 1ebbf54b4d95f1b19f684521ebf1b84f86e9293c
>> Parents: 5ae0e6c
>> Author: Matt Sicker <ma...@apache.org>
>> Authored: Sat Oct 4 18:40:42 2014 -0500
>> Committer: Matt Sicker <ma...@apache.org>
>> Committed: Sat Oct 4 18:40:42 2014 -0500
>>
>> ----------------------------------------------------------------------
>> .../log4j/jmx/gui/ClientEditConfigPanel.java | 3 +--
>> .../org/apache/logging/log4j/jmx/gui/ClientGui.java | 16 +++-------------
>> 2 files changed, 4 insertions(+), 15 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>>
>> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/1ebbf54b/log4j-jmx-gui/src/main/java/org/apache/logging/log4j/jmx/gui/ClientEditConfigPanel.java
>> ----------------------------------------------------------------------
>> diff --git
>> a/log4j-jmx-gui/src/main/java/org/apache/logging/log4j/jmx/gui/ClientEditConfigPanel.java
>> b/log4j-jmx-gui/src/main/java/org/apache/logging/log4j/jmx/gui/ClientEditConfigPanel.java
>> index 51d6468..972e0bb 100644
>> ---
>> a/log4j-jmx-gui/src/main/java/org/apache/logging/log4j/jmx/gui/ClientEditConfigPanel.java
>> +++
>> b/log4j-jmx-gui/src/main/java/org/apache/logging/log4j/jmx/gui/ClientEditConfigPanel.java
>> @@ -128,8 +128,7 @@ public class ClientEditConfigPanel extends JPanel {
>> // configTextArea.setEditable(false);
>> configTextArea.setBackground(Color.white);
>> configTextArea.setForeground(Color.black);
>> - configTextArea.setFont(new Font("Monospaced", Font.PLAIN,
>> - configTextArea.getFont().getSize()));
>> + configTextArea.setFont(new Font(Font.MONOSPACED, Font.PLAIN,
>> configTextArea.getFont().getSize()));
>> final JScrollPane scrollConfig = new JScrollPane(configTextArea);
>>
>> locationTextField = new JTextField(LOCATION_TEXT_COLS);
>>
>>
>> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/1ebbf54b/log4j-jmx-gui/src/main/java/org/apache/logging/log4j/jmx/gui/ClientGui.java
>> ----------------------------------------------------------------------
>> diff --git
>> a/log4j-jmx-gui/src/main/java/org/apache/logging/log4j/jmx/gui/ClientGui.java
>> b/log4j-jmx-gui/src/main/java/org/apache/logging/log4j/jmx/gui/ClientGui.java
>> index 67a8018..0215fb5 100644
>> ---
>> a/log4j-jmx-gui/src/main/java/org/apache/logging/log4j/jmx/gui/ClientGui.java
>> +++
>> b/log4j-jmx-gui/src/main/java/org/apache/logging/log4j/jmx/gui/ClientGui.java
>> @@ -40,17 +40,7 @@ import javax.management.ObjectName;
>> import javax.management.remote.JMXConnector;
>> import javax.management.remote.JMXConnectorFactory;
>> import javax.management.remote.JMXServiceURL;
>> -import javax.swing.AbstractAction;
>> -import javax.swing.JFrame;
>> -import javax.swing.JOptionPane;
>> -import javax.swing.JPanel;
>> -import javax.swing.JScrollPane;
>> -import javax.swing.JTabbedPane;
>> -import javax.swing.JTextArea;
>> -import javax.swing.JToggleButton;
>> -import javax.swing.ScrollPaneConstants;
>> -import javax.swing.SwingUtilities;
>> -import javax.swing.UIManager;
>> +import javax.swing.*;
>> import javax.swing.UIManager.LookAndFeelInfo;
>>
>> import org.apache.logging.log4j.core.jmx.LoggerContextAdminMBean;
>> @@ -142,7 +132,7 @@ public class ClientGui extends JPanel implements
>> NotificationListener {
>> result.setEditable(false);
>> result.setBackground(this.getBackground());
>> result.setForeground(Color.black);
>> - result.setFont(new Font("Monospaced", Font.PLAIN,
>> result.getFont().getSize()));
>> + result.setFont(new Font(Font.MONOSPACED, Font.PLAIN,
>> result.getFont().getSize()));
>> result.setWrapStyleWord(true);
>> return result;
>> }
>> @@ -284,7 +274,7 @@ public class ClientGui extends JPanel implements
>> NotificationListener {
>> try {
>> final ClientGui gui = new ClientGui(client);
>> final JFrame frame = new JFrame(title);
>> - frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
>> +
>> frame.setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);
>> frame.getContentPane().add(gui, BorderLayout.CENTER);
>> frame.pack();
>> frame.setVisible(true);
>>
>>
>