[GitHub] [solr] epugh commented on a diff in pull request #1220: SOLR-10463: setRetryExpiryTime should be deprecated in favor of Solr Client Builder methods

[GitBox <gi...@apache.org>]

epugh commented on code in PR #1220:
URL: https://github.com/apache/solr/pull/1220#discussion_r1049791072


##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##########
@@ -245,6 +249,16 @@ public Builder withParallelUpdates(boolean parallelUpdates) {
       return this;
     }
 
+    /**
+     * This is the time to wait to refetch the state after getting the same state version from ZK
+     *
+     * <p>secs
+     */
+    public Builder setRetryExpiryTime(int secs) {

Review Comment:
   are you suggesting the method look like "public Builder setRetryExpiryTime(int secs, TimeUnit seconds)"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org