[GitHub] [spark] nchammas commented on issue #27800: [SPARK-31041][BUILD] Make arguments to make-distribution.sh position-independent

[GitBox <gi...@apache.org>]

nchammas commented on issue #27800: [SPARK-31041][BUILD] Make arguments to make-distribution.sh position-independent
URL: https://github.com/apache/spark/pull/27800#issuecomment-595287789
 
 
   OK, new debug statements:
   
   ```diff
   diff --git a/dev/make-distribution.sh b/dev/make-distribution.sh
   index 3c562b0f91..cb68610836 100755
   --- a/dev/make-distribution.sh
   +++ b/dev/make-distribution.sh
   @@ -90,6 +90,15 @@ while (( "$#" )); do
      shift
    done
    
   +echo "--tgz $MAKE_TGZ"
   +echo "--pip $MAKE_PIP"
   +echo "--r $MAKE_R"
   +echo "--mvn $MVN"
   +echo "--name $NAME"
   +echo "mvn-opts: ${MAVEN_CLI_OPTS[@]}"
   +
   +# exit 1
   +
    if [ -z "$JAVA_HOME" ]; then
      # Fall back on JAVA_HOME from rpm, if found
      if [ $(command -v  rpm) ]; then
   @@ -148,6 +157,13 @@ SPARK_HIVE=$("$MVN" help:evaluate -Dexpression=project.activeProfiles -pl sql/hi
        # because we use "set -o pipefail"
        echo -n)
    
   +echo "VERSION: $VERSION"
   +echo "SCALA_VERSION: $SCALA_VERSION"
   +echo "SPARK_HADOOP_VERSION: $SPARK_HADOOP_VERSION"
   +echo "SPARK_HIVE: $SPARK_HIVE"
   +
   +exit 1
   +
    if [ "$NAME" == "none" ]; then
      NAME=$SPARK_HADOOP_VERSION
    fi
   ```
   
   And new tests:
   
   ```sh
   $ ./dev/make-distribution.sh --pip -r --tgz
   
   Using `mvn` from path: .../spark/build/apache-maven-3.6.3/bin/mvn
   Unable to parse command line options: Unrecognized option: -r
   + VERSION=' -X,--debug                             Produce execution debug output'
   ```
   
   ```sh
   $ ./dev/make-distribution.sh \
       --name custom-spark \
       --pip --r --tgz \
       -Psparkr \
       -Phadoop-2.7 \
       -Phive -Phive-thriftserver \
       -Pmesos -Pyarn -Pkubernetes
   
   VERSION: 3.1.0-SNAPSHOT
   SCALA_VERSION: 2.12
   SPARK_HADOOP_VERSION: 2.7.4
   SPARK_HIVE: 1
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org