You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "majialoong (via GitHub)" <gi...@apache.org> on 2025/11/12 16:43:50 UTC
[PR] [ISSUE #9849] Correct ACL cache loader error log in ClusterMetadataService [rocketmq]
majialoong opened a new pull request, #9850:
URL: https://github.com/apache/rocketmq/pull/9850
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #9849
### Brief Description
Use the correct log message when ACL information fails to load.
### How Did You Test This Change?
local test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #9849] Correct ACL cache loader error log in ClusterMetadataService [rocketmq]
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin merged PR #9850:
URL: https://github.com/apache/rocketmq/pull/9850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #9849] Correct ACL cache loader error log in ClusterMetadataService [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #9850:
URL: https://github.com/apache/rocketmq/pull/9850#issuecomment-3523029746
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/9850?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.26%. Comparing base ([`3b78ab0`](https://app.codecov.io/gh/apache/rocketmq/commit/3b78ab09608fed81c4bcb1d621d82520a89e818b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6369a1`](https://app.codecov.io/gh/apache/rocketmq/commit/b6369a19a2d8c38a1ff10b25a9c487685acfb79e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/rocketmq/pull/9850?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...proxy/service/metadata/ClusterMetadataService.java](https://app.codecov.io/gh/apache/rocketmq/pull/9850?src=pr&el=tree&filepath=proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fproxy%2Fservice%2Fmetadata%2FClusterMetadataService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3NlcnZpY2UvbWV0YWRhdGEvQ2x1c3Rlck1ldGFkYXRhU2VydmljZS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/9850?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #9850 +/- ##
=============================================
- Coverage 48.33% 48.26% -0.08%
+ Complexity 12258 12238 -20
=============================================
Files 1314 1314
Lines 93799 93799
Branches 12036 12036
=============================================
- Hits 45335 45269 -66
- Misses 42854 42923 +69
+ Partials 5610 5607 -3
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/9850?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #9849] Correct ACL cache loader error log in ClusterMetadataService [rocketmq]
Posted by "majialoong (via GitHub)" <gi...@apache.org>.
majialoong commented on PR #9850:
URL: https://github.com/apache/rocketmq/pull/9850#issuecomment-3530554991
Hi, @dingshuangxi888, @RongtongJin , @lizhimins , PTAL when you get a chance, thanks in advance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org