You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "PDavid (via GitHub)" <gi...@apache.org> on 2024/11/22 08:38:27 UTC
[PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
PDavid opened a new pull request, #6490:
URL: https://github.com/apache/hbase/pull/6490
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on code in PR #6490:
URL: https://github.com/apache/hbase/pull/6490#discussion_r1853542763
##########
hbase-server/src/main/resources/hbase-webapps/master/table.jsp:
##########
@@ -1267,9 +1275,7 @@ Actions:
</div>
<jsp:include page="footer.jsp" />
-<script src="/static/js/jquery.min.js" type="text/javascript"></script>
<script src="/static/js/jquery.tablesorter.min.js" type="text/javascript"></script>
-<script src="/static/js/bootstrap.min.js" type="text/javascript"></script>
Review Comment:
Here I removed these JavaScript includes because `footer.jsp` is included just above and that includes these already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2514478064
Hi @NihalJain,
If you'll have some time, can you please review this? :pray:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2497008988
The `TestRegionServerReportForDuty` test has been failed in the PR build because of timeout - it is unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "ndimiduk (via GitHub)" <gi...@apache.org>.
ndimiduk commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2545747834
You can present a single PR for all the backports for a particular branch. However, our process requires one commit per JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6490:
URL: https://github.com/apache/hbase/pull/6490#discussion_r1875438618
##########
hbase-server/src/main/resources/hbase-webapps/master/table.jsp:
##########
@@ -30,20 +29,17 @@
import="java.util.HashSet"
import="java.util.Optional"
import="java.util.TreeMap"
- import="java.util.concurrent.TimeoutException"
import="java.util.concurrent.TimeUnit"
import="org.apache.commons.lang3.StringEscapeUtils"
import="org.apache.hadoop.conf.Configuration"
import="org.apache.hadoop.hbase.HConstants"
import="org.apache.hadoop.hbase.HRegionLocation"
- import="org.apache.hadoop.hbase.NotServingRegionException"
import="org.apache.hadoop.hbase.RegionMetrics"
import="org.apache.hadoop.hbase.RegionMetricsBuilder"
import="org.apache.hadoop.hbase.ServerMetrics"
import="org.apache.hadoop.hbase.ServerName"
import="org.apache.hadoop.hbase.Size"
import="org.apache.hadoop.hbase.TableName"
- import="org.apache.hadoop.hbase.TableNotFoundException"
import="org.apache.hadoop.hbase.client.AsyncAdmin"
import="org.apache.hadoop.hbase.client.AsyncConnection"
Review Comment:
All the removed imports were redundant right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2531860420
Prepared backport PR-s for the active branches here:
- https://github.com/apache/hbase/pull/6524
- https://github.com/apache/hbase/pull/6525
- https://github.com/apache/hbase/pull/6526
- https://github.com/apache/hbase/pull/6527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2493890332
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 35s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 5s | | master passed |
| +1 :green_heart: | compile | 2m 10s | | master passed |
| +1 :green_heart: | javadoc | 3m 45s | | master passed |
| +1 :green_heart: | shadedjars | 5m 21s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 52s | | the patch passed |
| +1 :green_heart: | compile | 2m 2s | | the patch passed |
| +1 :green_heart: | javac | 2m 2s | | the patch passed |
| +1 :green_heart: | javadoc | 3m 46s | | the patch passed |
| +1 :green_heart: | shadedjars | 5m 18s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 300m 57s | | root in the patch passed. |
| | | 337m 27s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6490 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 396bb6681628 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a836f2641dd201899e5692dd952cbb7dcac8a6eb |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/1/testReport/ |
| Max. process+thread count | 9277 (vs. ulimit of 30000) |
| modules | C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/1/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2537461031
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 31s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | jshint | 0m 0s | | jshint was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 46s | | master passed |
| +1 :green_heart: | compile | 9m 47s | | master passed |
| +1 :green_heart: | checkstyle | 1m 19s | | master passed |
| +1 :green_heart: | spotbugs | 16m 16s | | master passed |
| +1 :green_heart: | spotless | 1m 9s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 46s | | the patch passed |
| +1 :green_heart: | compile | 9m 17s | | the patch passed |
| +1 :green_heart: | javac | 9m 17s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 1m 19s | | the patch passed |
| +1 :green_heart: | shellcheck | 0m 0s | | No new issues. |
| +1 :green_heart: | spotbugs | 13m 22s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 12m 9s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 48s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 54s | | The patch does not generate ASF License warnings. |
| | | 84m 11s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/7/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6490 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless jshint shellcheck shelldocs |
| uname | Linux 6173253c58ed 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / bbe00c032a70b5d9bc18e19467562cc1d43bf489 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 188 (vs. ulimit of 30000) |
| modules | C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/7/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2538633856
> > Prepared backport PR-s for the active branches here:
> >
> > * branch-2: [HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6524](https://github.com/apache/hbase/pull/6524)
> > * branch-2.5: [HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6525](https://github.com/apache/hbase/pull/6525)
> > * branch-2.6: [HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6526](https://github.com/apache/hbase/pull/6526)
> > * branch-3: [HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6527](https://github.com/apache/hbase/pull/6527)
>
> Hi @PDavid thanks for all the backports, would be really helpful if you could mention the why the diffs are substantially smaller in branch-2.x vs master, a brief summary should suffice mentioning any extra/missing changes worth reviewing over there
Hi @NihalJain,
Sure thing, thanks.
So in the branch-2.x branches the web code is a bit different (I think some patches were not merged there in the past). Differences are for example:
- in some of the branch-2.x branches there are no `header.jsp` / `footer.jsp` in `hbase-rest` and `hbase-thrift` (or they are there for rest but not for thrift, etc)
- there is no `processRest.jsp`
- navbars do not contain the dropdown for Prometheus links.
- also `table.jsp` was a little bit different - for example most of those imports which were unused on master were still used on branch-2.x
So because the web code was different, when I cherry-picked my commits I had to adapt the changes.
I hope this answers your question. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2517289721
Thanks @PDavid. Let me do another round of testing and come back to you soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2529447332
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 36s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 48s | | master passed |
| +1 :green_heart: | compile | 2m 27s | | master passed |
| +1 :green_heart: | javadoc | 4m 20s | | master passed |
| +1 :green_heart: | shadedjars | 6m 53s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 39s | | the patch passed |
| +1 :green_heart: | compile | 2m 25s | | the patch passed |
| +1 :green_heart: | javac | 2m 25s | | the patch passed |
| +1 :green_heart: | javadoc | 4m 7s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 20s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 287m 2s | [/patch-unit-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/5/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-root.txt) | root in the patch failed. |
| | | 328m 27s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6490 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 4330e8a32b08 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / da710403260b1fad600c5acb7002a27a04f6a92c |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/5/testReport/ |
| Max. process+thread count | 5243 (vs. ulimit of 30000) |
| modules | C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/5/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain merged PR #6490:
URL: https://github.com/apache/hbase/pull/6490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on code in PR #6490:
URL: https://github.com/apache/hbase/pull/6490#discussion_r1853542763
##########
hbase-server/src/main/resources/hbase-webapps/master/table.jsp:
##########
@@ -1267,9 +1275,7 @@ Actions:
</div>
<jsp:include page="footer.jsp" />
-<script src="/static/js/jquery.min.js" type="text/javascript"></script>
<script src="/static/js/jquery.tablesorter.min.js" type="text/javascript"></script>
-<script src="/static/js/bootstrap.min.js" type="text/javascript"></script>
Review Comment:
Here I removed these JQuery and Bootstrap JavaScript includes because `footer.jsp` is included just above and that includes these already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2517652723
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 47s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available. |
| +0 :ok: | jshint | 0m 1s | | jshint was not available. |
| +0 :ok: | shelldocs | 0m 1s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 8s | | master passed |
| +1 :green_heart: | compile | 13m 41s | | master passed |
| +1 :green_heart: | checkstyle | 1m 56s | | master passed |
| +1 :green_heart: | spotbugs | 19m 20s | | master passed |
| +1 :green_heart: | spotless | 1m 18s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 19s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 59s | | the patch passed |
| +1 :green_heart: | compile | 14m 28s | | the patch passed |
| +1 :green_heart: | javac | 14m 28s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 1m 54s | | the patch passed |
| +1 :green_heart: | shellcheck | 0m 0s | | No new issues. |
| +1 :green_heart: | spotbugs | 15m 24s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 11m 57s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 46s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 54s | | The patch does not generate ASF License warnings. |
| | | 102m 36s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6490 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless jshint shellcheck shelldocs |
| uname | Linux e26d2af99bc7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d8541cf048246139530d3b5d95d30431677bc410 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 190 (vs. ulimit of 30000) |
| modules | C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/3/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2527470962
> > Hi @NihalJain!
> > Many thanks, I applied your suggestion and it seems to fix the issue.
>
> Awesome @PDavid, thanks for this great effort. 👏
>
> Would you be able to backport this change to all active branches? I would not want to land this only in master as
>
> 1. this is a security fix
> 2. it will be a pain managing different web code in older versions
Sure @NihalJain, I will backport this change to all active branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2538330594
> Prepared backport PR-s for the active branches here:
>
> * branch-2: [HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6524](https://github.com/apache/hbase/pull/6524)
> * branch-2.5: [HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6525](https://github.com/apache/hbase/pull/6525)
> * branch-2.6: [HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6526](https://github.com/apache/hbase/pull/6526)
> * branch-3: [HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6527](https://github.com/apache/hbase/pull/6527)
Hi @PDavid thanks for all the backports, would be really helpful if you could mention the why the diffs are substantially smaller in branch-2.x vs master, a brief summary should suffice mentioning any extra/missing changes worth reviewing over there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2518227722
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 54s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 43s | | master passed |
| +1 :green_heart: | compile | 1m 54s | | master passed |
| +1 :green_heart: | javadoc | 3m 28s | | master passed |
| +1 :green_heart: | shadedjars | 4m 51s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 37s | | the patch passed |
| +1 :green_heart: | compile | 1m 55s | | the patch passed |
| +1 :green_heart: | javac | 1m 55s | | the patch passed |
| +1 :green_heart: | javadoc | 3m 32s | | the patch passed |
| +1 :green_heart: | shadedjars | 4m 50s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 290m 15s | | root in the patch passed. |
| | | 325m 16s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6490 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 6e2edaf54c6a 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d8541cf048246139530d3b5d95d30431677bc410 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/3/testReport/ |
| Max. process+thread count | 8945 (vs. ulimit of 30000) |
| modules | C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/3/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2535919063
With more testing I found some smaller issues which I now fixed and just pushed. I think this is ready now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2493524194
Many thanks @NihalJain !
I'll wait for the CI build and then I'll change this PR to ready to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2517278024
OK, now the pages are looking like this:


Also fixed a smaller issue with the pagination in jqSpager.js (used by the "Regions in Transition" section on master status page) so that the paginator links are styled and displayed properly.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2527382783
> > Hi @PDavid I have reviewed the updated pages and also had a look at REST and THRIFT pages. All looks good to me.
> > Just a NIT: Can we fix this? I see two lines in all table boundaries. For eg:
> >
> > 1. 
> > 2. 
> >
> > Can be fixed by replacing with `border-style: solid` with `border-top: 1px solid #ddd;`? 
> > Not important though, you can decide if you would want to fix.
>
> Hi @NihalJain!
>
> Thanks for the detailed checks and the suggestion. 👍 I'll have a look and fix this.
Hi @NihalJain!
Many thanks, I applied your suggestion and it seems to fix the issue.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2527432240
> Hi @NihalJain!
>
> Many thanks, I applied your suggestion and it seems to fix the issue.
Awesome @PDavid, thanks for this great effort. 👏
Would you be able to backport this change to all active branches? I would not want to land this only in master as
1) this is a security fix
2) it will be a pain managing different web code in older versions
> My front end experience is minimal, so I'm not really qualified to review this.
Thank you @stoty can understand. Would be helpful even if you can start hbase in a local dev build and try out the new Web UI and see if everything looks good? Anyways, I have reviewed the code changes, they look good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2527150463
+1, LGTM
Hi @Apache9, @ndimiduk, @stoty Got some bandwidth to check this out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2538830490
> @PDavid if you can identify specific JIRAs that need to be backported, i find that it's better/easier to do that work than to maintain and enhance divergence between the branches. If you're up for it, can you backport those missing changes and rebase your branch-2 changes here on top of those backports?
Hi @ndimiduk,
Thanks for your suggestion, this actually makes perfect sense. I'll do this then.
These are missing for sure from some of the branch-2.x branches:
- https://issues.apache.org/jira/browse/HBASE-27406, https://github.com/apache/hbase/pull/4833
- https://issues.apache.org/jira/browse/HBASE-19291, https://github.com/apache/hbase/commit/3b2b22b5fac1175302b320b7ca1ed766326924cc
I'll look for the other differences.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2527175682
My front end experience is minimal, so I'm not really qualified to review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2527194522
> Hi @PDavid I have reviewed the updated pages and also had a look at REST and THRIFT pages. All looks good to me.
>
> Just a NIT: Can we fix this? I see two lines in all table boundaries. For eg:
>
> 1. 
>
> 2. 
>
> Can be fixed by replacing with `border-style: solid` with `border-top: 1px solid #ddd;`? 
>
> Not important though, you can decide if you would want to fix.
Hi @NihalJain!
Thanks for the detailed checks and the suggestion. :+1:
I'll have a look and fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2537313293
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 36s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 39s | | master passed |
| +1 :green_heart: | compile | 1m 50s | | master passed |
| +1 :green_heart: | javadoc | 3m 30s | | master passed |
| +1 :green_heart: | shadedjars | 4m 49s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 34s | | the patch passed |
| +1 :green_heart: | compile | 1m 54s | | the patch passed |
| +1 :green_heart: | javac | 1m 54s | | the patch passed |
| +1 :green_heart: | javadoc | 3m 32s | | the patch passed |
| +1 :green_heart: | shadedjars | 4m 51s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 520m 40s | [/patch-unit-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/6/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-root.txt) | root in the patch failed. |
| | | 554m 47s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6490 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 409e5e2efda6 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 97972c80963c134be0349522a06c1dab8375ff98 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/6/testReport/ |
| Max. process+thread count | 5916 (vs. ulimit of 30000) |
| modules | C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/6/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2536134275
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 32s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | jshint | 0m 0s | | jshint was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 38s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 29s | | master passed |
| +1 :green_heart: | compile | 7m 59s | | master passed |
| +1 :green_heart: | checkstyle | 1m 9s | | master passed |
| +1 :green_heart: | spotbugs | 11m 15s | | master passed |
| +1 :green_heart: | spotless | 0m 44s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 3s | | the patch passed |
| +1 :green_heart: | compile | 7m 58s | | the patch passed |
| +1 :green_heart: | javac | 7m 58s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 1m 9s | | the patch passed |
| +1 :green_heart: | shellcheck | 0m 0s | | No new issues. |
| +1 :green_heart: | spotbugs | 14m 42s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 14m 0s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 57s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 2s | | The patch does not generate ASF License warnings. |
| | | 79m 2s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/6/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6490 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless jshint shellcheck shelldocs |
| uname | Linux 464a8f5190d1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 97972c80963c134be0349522a06c1dab8375ff98 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 191 (vs. ulimit of 30000) |
| modules | C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/6/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2494050927
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 29s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | jshint | 0m 0s | | jshint was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 13s | | master passed |
| +1 :green_heart: | compile | 7m 56s | | master passed |
| +1 :green_heart: | checkstyle | 1m 10s | | master passed |
| +1 :green_heart: | spotbugs | 11m 9s | | master passed |
| +1 :green_heart: | spotless | 0m 44s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 3s | | the patch passed |
| +1 :green_heart: | compile | 7m 55s | | the patch passed |
| +1 :green_heart: | javac | 7m 55s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 1m 12s | | the patch passed |
| +1 :green_heart: | shellcheck | 0m 0s | | No new issues. |
| +1 :green_heart: | spotbugs | 11m 43s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 11m 33s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 43s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 51s | | The patch does not generate ASF License warnings. |
| | | 70m 26s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6490 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless jshint shellcheck shelldocs |
| uname | Linux 26dddd31dfa4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / aefcd2d2d14db948a048c36c60236aecf0fea507 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 192 (vs. ulimit of 30000) |
| modules | C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/2/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2494606929
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 44s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 2s | | master passed |
| +1 :green_heart: | compile | 2m 5s | | master passed |
| +1 :green_heart: | javadoc | 3m 44s | | master passed |
| +1 :green_heart: | shadedjars | 5m 21s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 51s | | the patch passed |
| +1 :green_heart: | compile | 2m 6s | | the patch passed |
| +1 :green_heart: | javac | 2m 6s | | the patch passed |
| +1 :green_heart: | javadoc | 3m 49s | | the patch passed |
| +1 :green_heart: | shadedjars | 5m 21s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 247m 54s | [/patch-unit-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/2/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-root.txt) | root in the patch failed. |
| | | 283m 16s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6490 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 9fe009ab28c8 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / aefcd2d2d14db948a048c36c60236aecf0fea507 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/2/testReport/ |
| Max. process+thread count | 6387 (vs. ulimit of 30000) |
| modules | C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/2/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on code in PR #6490:
URL: https://github.com/apache/hbase/pull/6490#discussion_r1853542763
##########
hbase-server/src/main/resources/hbase-webapps/master/table.jsp:
##########
@@ -1267,9 +1275,7 @@ Actions:
</div>
<jsp:include page="footer.jsp" />
-<script src="/static/js/jquery.min.js" type="text/javascript"></script>
<script src="/static/js/jquery.tablesorter.min.js" type="text/javascript"></script>
-<script src="/static/js/bootstrap.min.js" type="text/javascript"></script>
Review Comment:
Here I removed these JQuery and Bootstrap JavaScript includes because `footer.jsp` is included just above and that includes these already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "ndimiduk (via GitHub)" <gi...@apache.org>.
ndimiduk commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2551249761
I think that all four of these Jiras are fine to backport to active release lines. It's a shame they weren't backported originally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2516426378
Hi @PDavid I checked out code and had a look at Master and RS pages. All pages seem to work perfectly fine in these 2 web UIs, that's great work, thanks :)
Have a few suggestions though
---
1) **Styling/Colors**
Can we make the UI coloring look similar to what we had before? For example now the blue colors are very dark over the dull blue we had earlier, which was no very heavy on eyes.
You could try to override default bootstrap.css in hbase.css? For example replacing reference to #0d6efd with #337ab7 results in following.
With above change, page looks a lot like before wrt blue colors:

Would need to compare with old HBase UI where ever we have discrepancy in colors.
---
2) **Active Tab Indicator**
Also the active navbar highlighting is either broken or not as before. Can this be fixed? This is it rendered earlier

---
Have not looked at code changes line by line as of yet, have just tried the change locally. Will review code and other web pages soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2493510120
Thanks for working on this @PDavid. Will try to build code locally and review the changes once the PR is ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2493377571
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 52s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | jshint | 0m 0s | | jshint was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 3s | | master passed |
| +1 :green_heart: | compile | 9m 31s | | master passed |
| +1 :green_heart: | checkstyle | 1m 10s | | master passed |
| +1 :green_heart: | spotbugs | 11m 27s | | master passed |
| +1 :green_heart: | spotless | 0m 44s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 1s | | the patch passed |
| +1 :green_heart: | compile | 8m 5s | | the patch passed |
| +1 :green_heart: | javac | 8m 5s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 1m 9s | [/results-checkstyle-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/1/artifact/yetus-general-check/output/results-checkstyle-root.txt) | root: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) |
| +1 :green_heart: | shellcheck | 0m 0s | | No new issues. |
| +1 :green_heart: | spotbugs | 11m 59s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 10m 25s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 41s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 4s | | The patch does not generate ASF License warnings. |
| | | 71m 3s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6490 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless jshint shellcheck shelldocs |
| uname | Linux 5464398d1ae0 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a836f2641dd201899e5692dd952cbb7dcac8a6eb |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 191 (vs. ulimit of 30000) |
| modules | C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/1/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on code in PR #6490:
URL: https://github.com/apache/hbase/pull/6490#discussion_r1853586774
##########
hbase-server/src/main/resources/hbase-webapps/master/table.jsp:
##########
@@ -1267,9 +1287,7 @@ Actions:
</div>
<jsp:include page="footer.jsp" />
-<script src="/static/js/jquery.min.js" type="text/javascript"></script>
<script src="/static/js/jquery.tablesorter.min.js" type="text/javascript"></script>
-<script src="/static/js/bootstrap.min.js" type="text/javascript"></script>
Review Comment:
Here I removed these JQuery and Bootstrap JavaScript includes because footer.jsp is included just above and that includes these already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2537404571
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 44s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 44s | | master passed |
| +1 :green_heart: | compile | 1m 53s | | master passed |
| +1 :green_heart: | javadoc | 3m 28s | | master passed |
| +1 :green_heart: | shadedjars | 4m 50s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 59s | | the patch passed |
| +1 :green_heart: | compile | 2m 47s | | the patch passed |
| +1 :green_heart: | javac | 2m 47s | | the patch passed |
| +1 :green_heart: | javadoc | 3m 40s | | the patch passed |
| +1 :green_heart: | shadedjars | 5m 4s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 2m 51s | [/patch-unit-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/7/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-root.txt) | root in the patch failed. |
| | | 34m 34s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/7/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6490 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux d11c45156abc 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / bbe00c032a70b5d9bc18e19467562cc1d43bf489 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/7/testReport/ |
| Max. process+thread count | 311 (vs. ulimit of 30000) |
| modules | C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/7/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "ndimiduk (via GitHub)" <gi...@apache.org>.
ndimiduk commented on code in PR #6490:
URL: https://github.com/apache/hbase/pull/6490#discussion_r1881725285
##########
hbase-server/src/main/resources/hbase-webapps/static/favicon.ico:
##########
Review Comment:
Hah, nice :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2527146743
Hi @PDavid I have reviewed the updated pages and also had a look at REST and THRIFT pages. All looks good to me.
Just a NIT: Can we fix this? I see two lines in all table boundaries. For eg:
1) 
2) 
---
Can be fixed simply by replacing with `border-style: solid` with `border-top: 1px solid #ddd;`

---
New

---
Not important though, you can decide if you would want to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2527578791
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 34s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | jshint | 0m 0s | | jshint was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 46s | | master passed |
| +1 :green_heart: | compile | 9m 3s | | master passed |
| +1 :green_heart: | checkstyle | 1m 20s | | master passed |
| +1 :green_heart: | spotbugs | 13m 56s | | master passed |
| +1 :green_heart: | spotless | 0m 49s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 29s | | the patch passed |
| +1 :green_heart: | compile | 9m 25s | | the patch passed |
| +1 :green_heart: | javac | 9m 25s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 1m 26s | | the patch passed |
| +1 :green_heart: | shellcheck | 0m 0s | | No new issues. |
| +1 :green_heart: | spotbugs | 14m 12s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 11m 45s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 53s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 55s | | The patch does not generate ASF License warnings. |
| | | 80m 43s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6490 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless jshint shellcheck shelldocs |
| uname | Linux 87d29541e2f8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 9cdba18082ac0843475394fb406f2d076b7ff956 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 190 (vs. ulimit of 30000) |
| modules | C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/4/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2545790000
> Hi @ndimiduk and @NihalJain, I prepared the following backport PR-s:
>
> * branch-2.5: [HBASE-29028 Backport missing UI patches to branch-2.5 #6542](https://github.com/apache/hbase/pull/6542)
> * branch-2.6: [HBASE-29028 Backport missing UI patches to branch-2.6 #6546](https://github.com/apache/hbase/pull/6546)
> * branch-2: [HBASE-29028 Backport missing UI patches to branch-2 #6548](https://github.com/apache/hbase/pull/6548)
>
> What do you think? Is the approach good or should we have one PR per patch?
Thank you @PDavid for the effort. Will have a look at the changes and reply back soon. Will hold merging this for now so that we can revisit/rebase backport of this PR once the new PRs for each branch is merged. Hopefully backports will be a lot similar post the missing JIRAs commit.
FYI @apurtell @Apache9: I hope you are fine with backporting missing JIRAs to active 2.x branches with #6542
, #6546 and #6548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2516497981
> To be completely honest I was not sure how important it is to preserve the look and styling of the current HBase UI. Of course I'll' look into it and restore these.
>
Thats right. As long as it looks visually same/better we are good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on code in PR #6490:
URL: https://github.com/apache/hbase/pull/6490#discussion_r1853589065
##########
hbase-thrift/src/main/resources/hbase-webapps/static/hbase_logo_small.png:
##########
Review Comment:
Here I replaced hbase_logo_small.png under thrift module with the hbase-server one. Reason: to make sure that they are the same size (this under thrift was smaller).
If required this can be undone but I think it is more consistent this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2545640314
Hi @ndimiduk and @NihalJain,
I prepared the following backport PR-s:
- branch-2.5: https://github.com/apache/hbase/pull/6542
- branch-2.6: https://github.com/apache/hbase/pull/6546
- branch-2: https://github.com/apache/hbase/pull/6548
What do you think? Is the approach good or should we have one PR per patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2527151651
Also please ensure to sync JIRA title and PR title
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on code in PR #6490:
URL: https://github.com/apache/hbase/pull/6490#discussion_r1875525241
##########
hbase-server/src/main/resources/hbase-webapps/master/table.jsp:
##########
@@ -30,20 +29,17 @@
import="java.util.HashSet"
import="java.util.Optional"
import="java.util.TreeMap"
- import="java.util.concurrent.TimeoutException"
import="java.util.concurrent.TimeUnit"
import="org.apache.commons.lang3.StringEscapeUtils"
import="org.apache.hadoop.conf.Configuration"
import="org.apache.hadoop.hbase.HConstants"
import="org.apache.hadoop.hbase.HRegionLocation"
- import="org.apache.hadoop.hbase.NotServingRegionException"
import="org.apache.hadoop.hbase.RegionMetrics"
import="org.apache.hadoop.hbase.RegionMetricsBuilder"
import="org.apache.hadoop.hbase.ServerMetrics"
import="org.apache.hadoop.hbase.ServerName"
import="org.apache.hadoop.hbase.Size"
import="org.apache.hadoop.hbase.TableName"
- import="org.apache.hadoop.hbase.TableNotFoundException"
import="org.apache.hadoop.hbase.client.AsyncAdmin"
import="org.apache.hadoop.hbase.client.AsyncConnection"
Review Comment:
Exactly. These were unused imports which were highlighted by IntelliJ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2527192963
> Also @PDavid please ensure to sync JIRA title and PR title
Thanks, I changed the PR title to be the same as the Jira title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2516485584
> Hi @PDavid I checked out code and had a look at Master and RS pages. All pages seem to work perfectly fine in these 2 web UIs, that's great work, thanks :)
>
> ## Have a few suggestions though
> 1. **Styling/Colors**
>
> Can we make the UI coloring look similar to what we had before? For example now the blue colors are very dark over the dull blue we had earlier, which was not very heavy on eyes.
>
> You could try to override default bootstrap.css in hbase.css? For example replacing reference to #0d6efd with #337ab7 results in following.
>
> 
>
> Would need to compare with old HBase UI where ever we have noticeable discrepancy in colors. Although it should be fine if new colors looks better than before.
>
> 2. **Active Tab Indicator**
>
> Also the active navbar highlighting is either broken or not as before. Can this be fixed? This is how it used to render earlier
>
> 
>
> BTW I have not looked at code changes line by line as of yet, have just tried the change locally. Will review code and other web pages soon. Overall things look good to me visually.
Hi @NihalJain,
Many thanks for the feedback! :+1:
To be completely honest I was not sure how important it is to preserve the look and styling of the current HBase UI. Of course I'll' look into it and restore these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2560719588
Planning to merge this today to master and branch-3 (with #6527). We can merge the branch-2 backport of this one, once those PRs are rebased post missing patch PR merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "ndimiduk (via GitHub)" <gi...@apache.org>.
ndimiduk commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2538769201
@PDavid if you can identify specific JIRAs that need to be backported, i find that it's better/easier to do that work than to maintain and enhance divergence between the branches. If you're up for it, can you backport those missing changes and rebase your branch-2 changes here on top of those backports?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2528205281
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 41s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 8s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 43s | | master passed |
| +1 :green_heart: | compile | 1m 53s | | master passed |
| +1 :green_heart: | javadoc | 3m 27s | | master passed |
| +1 :green_heart: | shadedjars | 4m 50s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 37s | | the patch passed |
| +1 :green_heart: | compile | 1m 55s | | the patch passed |
| +1 :green_heart: | javac | 1m 55s | | the patch passed |
| +1 :green_heart: | javadoc | 3m 31s | | the patch passed |
| +1 :green_heart: | shadedjars | 4m 47s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 284m 13s | | root in the patch passed. |
| | | 318m 31s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6490 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 1eaabb12384b 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 9cdba18082ac0843475394fb406f2d076b7ff956 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/4/testReport/ |
| Max. process+thread count | 9106 (vs. ulimit of 30000) |
| modules | C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6490/4/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28832 Upgraded Bootstrap to 5 [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2515318596
> Hi @NihalJain,
>
> If you'll have some time, can you please review this? :pray:
Ah yes, caught up at work, will review as soon as I have some bandwidth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org