[jira] [Commented] (NET-528) FTPListParseEngine does not provide access to raw responses

["Sebb (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NET-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242931#comment-14242931 ] 

Sebb commented on NET-528:
--------------------------

Actually it is already possible to get the raw listing by overloading FTPFileEntryParser.preParse(List<String> original)

Alternatively one can provide a ProtocolCommandListener.

However neither of these is ideal, as they don't distinguish the successful files from the unsuccessful.
A crude way to fix this would be to compare with the list of FTPFiles and eliminate matching entries - rather awkard.

It would be easier to have a single list of FTPFile instances; the instances which failed to parse would need to be distinguishable, for example by using a special type.

> FTPListParseEngine does not provide access to raw responses
> -----------------------------------------------------------
>
>                 Key: NET-528
>                 URL: https://issues.apache.org/jira/browse/NET-528
>             Project: Commons Net
>          Issue Type: Improvement
>            Reporter: Sebb
>
> The FTPListParseEngine class reads the responses from the server and stores the lines in a list during the preparse phase.
> The parse phase creates the FTPFile entries from the raw strings. However, if parsing fails, nothing is returned. There is currently no way to access the unparsed string that failed the parsing.
> It would be useful to provide this access somehow.
> The FTPFile class does include the unparsed entry as one of its fields.
> However, currently the expectation is that only parsed entries will be returned, so it would be necessary to add a configuration option for the engine. This would probably need to be an FTPClient option that could be passed to the engine on construction or perhaps as a getFiles() parameter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)