[GitHub] [linkis] peacewong commented on a diff in pull request #4699: Flink support native kubernetes application mode

["peacewong (via GitHub)" <gi...@apache.org>]

peacewong commented on code in PR #4699:
URL: https://github.com/apache/linkis/pull/4699#discussion_r1242090640


##########
linkis-engineconn-plugins/flink/src/main/scala/org/apache/linkis/engineconnplugin/flink/config/FlinkEnvConfiguration.scala:
##########
@@ -91,6 +91,44 @@ object FlinkEnvConfiguration {
   val FLINK_CLIENT_REQUEST_TIMEOUT =
     CommonVars("flink.client.request.timeout", new TimeType("30s"))
 
+  val FLINK_EXECUTION_TARGET =
+    CommonVars("flink.execution.target", FlinkExecutionTargetType.YARN_PER_JOB)
+
+  val FLINK_KUBERNETES_CONFIG_FILE =
+    CommonVars(
+      "flink.kubernetes.config.file",

Review Comment:
   need to add linkis prefix



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org