You are viewing a plain text version of this content. The canonical link for it is here.
Posted to batik-dev@xmlgraphics.apache.org by Bill Haneman <bi...@ireland.sun.com> on 2000/11/20 01:48:27 UTC
[commit] Bug fix for out-of-turn rendering; text selection
Hi:
I have committed changes for two things: a bug fix for an out-of-turn
problem in the viewer (in certain situations when navigating through
forward and back buttons, the requests for display could get out-of-turn
and result in the wrong buffer being displayed). This was a
long-standing
bug, reproducible in the Oct-29 build.
Please note that the RendererFactory interface has an added method,
getRenderContext(). Also the Renderers can be instantiated with a
GraphicsNodeRenderContext when the RendererFactory creates them. If you
have issues with this please let me know and we can discuss alternate
solutions for the problem I was addressing.
I have also committed an initial version of test selection, with
full highlighting. I believe it to work for all rotations, pans,
scales, etc.
For some reason however it does not appear to work in Ausmap, though it
does in moscow.svgz... so I will be investigating that. Otherwise
the only known issues (other than minor cosmetic tuning) are:
-> test highlight sometimes seems too wide for very small text,
impairing
ability to highlight neighboring text lines - possibly a bug in
ConcreteTextNode.getPrimitiveBounds()
-> highlight is a different shape for click-to-select all vs.
drag-to-select, and may be a little off-center (bug in
ConcreteTextNode.getBounds())
-> Text selection occurs on all text mouse clicks, even links -
the spec suggests that selection should only happen if other
actions have not been defined for the same mouse gesture.
(Otherwise no harm done, links work as before).
-Bill
P.S. - the report below was truncated, there may be other changed files.
Most of the changes are very small
--------------------
Bug fix: fixed out-of-turn bug in document painting which could
cause displayed document to be out of sync with URI display.
Added text selection.
Modified Files:
sources/org/apache/batik/apps/svgviewer/Main.java
sources/org/apache/batik/apps/svgviewer/ViewerFrame.java
sources/org/apache/batik/gvt/Selectable.java
sources/org/apache/batik/gvt/Selector.java
sources/org/apache/batik/gvt/TextPainter.java
sources/org/apache/batik/gvt/renderer/RendererFactory.java
sources/org/apache/batik/refimpl/gvt/ConcreteTextNode.java
sources/org/apache/batik/refimpl/gvt/event/ConcreteEventDispatcher.java
sources/org/apache/batik/refimpl/gvt/renderer/BasicTextPainter.java
sources/org/apache/batik/refimpl/gvt/renderer/DynamicRenderer.java
sources/org/apache/batik/refimpl/gvt/renderer/DynamicRendererFactory.jav
a
sources/org/apache/batik/refimpl/gvt/renderer/StaticRenderer.java
sources/org/apache/batik/refimpl/gvt/renderer/StaticRendererFactory.java
sources/org/apache/batik/refimpl/gvt/text/ConcreteTextSelector.java
Removed files:
sources/org/apache/batik/test/gvt/SimpleTextDemo.java
sources/org/apache/batik/text/gvt/TestSelector.java
Added files:
sources/org/apache/batik/gvt/event/SelectionEvent.java
sources/org/apache/batik/gvt/event/SelectionListener.java
--
--------------
Bill Haneman
+1 353 1 849 0495