You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Lily Chen <li...@mesosphere.io> on 2015/07/02 01:54:05 UTC
Re: Review Request 34136: Add ContainerImage protobuf.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34136/#review90166
-----------------------------------------------------------
include/mesos/mesos.proto (line 1209)
<https://reviews.apache.org/r/34136/#comment143158>
Same issue as when MesosInfo is not present. What happens when there is no Appc message present in Image?
- Lily Chen
On June 22, 2015, 4:42 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34136/
> -----------------------------------------------------------
>
> (Updated June 22, 2015, 4:42 p.m.)
>
>
> Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add ContainerImage protobuf.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 8df1211165169c9595e0e6e85b5ddc404345ff70
>
> Diff: https://reviews.apache.org/r/34136/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 34136: Add ContainerImage protobuf.
Posted by Ian Downes <ia...@gmail.com>.
> On July 1, 2015, 4:54 p.m., Lily Chen wrote:
> > include/mesos/mesos.proto, line 1209
> > <https://reviews.apache.org/r/34136/diff/2/?file=989752#file989752line1209>
> >
> > Same issue as when MesosInfo is not present. What happens when there is no Appc message present in Image?
This is how we represent a union: a required type and then 1 or more optional messages for those types. Code is responsible for verifiying that the optional message is present to match the type.
- Ian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34136/#review90166
-----------------------------------------------------------
On June 22, 2015, 9:42 a.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34136/
> -----------------------------------------------------------
>
> (Updated June 22, 2015, 9:42 a.m.)
>
>
> Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add ContainerImage protobuf.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 8df1211165169c9595e0e6e85b5ddc404345ff70
>
> Diff: https://reviews.apache.org/r/34136/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>