[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #10284: [Fix] Fix the JSONUtils tool class time zone problem #10282

[GitBox <gi...@apache.org>]

caishunfeng commented on code in PR #10284:
URL: https://github.com/apache/dolphinscheduler/pull/10284#discussion_r893127646


##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java:
##########
@@ -82,6 +82,12 @@ private JSONUtils() {
         throw new UnsupportedOperationException("Construct JSONUtils");
     }
 
+    public static synchronized boolean setTimeZone(TimeZone timeZone) {
+        objectMapper.setTimeZone(timeZone);
+        logger.info("set timezone: {}", timeZone);

Review Comment:
   remove if not use.



##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java:
##########
@@ -82,6 +82,12 @@ private JSONUtils() {
         throw new UnsupportedOperationException("Construct JSONUtils");
     }
 
+    public static synchronized boolean setTimeZone(TimeZone timeZone) {

Review Comment:
   ```suggestion
       public static synchronized void setTimeZone(TimeZone timeZone) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org