[GitHub] [iceberg] danielcweeks commented on a diff in pull request #4830: Core: Add session catalog implementation for REST

[GitBox <gi...@apache.org>]

danielcweeks commented on code in PR #4830:
URL: https://github.com/apache/iceberg/pull/4830#discussion_r878588317


##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -269,12 +269,6 @@ public Builder withHeaders(Map<String, String> headers) {
       return this;
     }
 
-    public Builder withBearerAuth(String token) {
-      Preconditions.checkNotNull(token, "Invalid auth token: null");
-      baseHeaders.put(HttpHeaders.AUTHORIZATION, asBearer(token));

Review Comment:
   nit: seems like we can get by without a separate method to format the bearer token?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org