You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/12/06 22:30:09 UTC

Re: Review Request: Using minified javascript in the webui.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7855/#review14106
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On Nov. 6, 2012, 6:23 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7855/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2012, 6:23 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> Saves around 750KB of content to send over the wire, for little effort.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f 
>   src/webui/master/static/angular-1.0.0rc8.min.js PRE-CREATION 
>   src/webui/master/static/bootstrap/js/jquery-1.7.1.js PRE-CREATION 
>   src/webui/master/static/bootstrap/js/jquery-1.7.1.min.js PRE-CREATION 
>   src/webui/master/static/bootstrap/js/jquery.js 00c4e23a27b15f6158ea46a016beb0ae95c6596d 
>   src/webui/master/static/cubism.v1.min.js PRE-CREATION 
>   src/webui/master/static/d3.v2.min.js PRE-CREATION 
>   src/webui/master/static/index.html 5e03ef6d054fab962657c1598888e65232f4c7e3 
>   src/webui/master/static/pailer.html 80dcd7b349582cb1875d1a72745c9c22394c0a26 
>   src/webui/master/static/underscore-1.3.3.min.js PRE-CREATION 
>   src/webui/master/static/underscore-min.js 5a0cb3b008d213ef3ecd3147c51eed08d98e2c54 
> 
> Diff: https://reviews.apache.org/r/7855/diff/
> 
> 
> Testing
> -------
> 
> Local runs, made sure to not forget adding to the Makefile this time.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>