[GitHub] [flink-connector-kafka] chucheng92 commented on a diff in pull request #37: [FLINK-30274] Bump commons-collections 3.x to commons-collections4

["chucheng92 (via GitHub)" <gi...@apache.org>]

chucheng92 commented on code in PR #37:
URL: https://github.com/apache/flink-connector-kafka/pull/37#discussion_r1247988699


##########
flink-connector-kafka/pom.xml:
##########
@@ -72,6 +72,13 @@ under the License.
             <version>${kafka.version}</version>
         </dependency>
 
+        <!-- When flink-core bump to commons-collections4, we can remove it.-->

Review Comment:
   @MartijnVisser it will be removed when flink update finished. Now it'a circular.
   
   flink-python test case in flink reference flink-sql-connector-kafka（not uber jar, without commons-collections class）, so search it in flink and cause ClassNotFoundException. 
   
   And this kafka connector also reference flink-core. 
   
   Must break circular references from side. Is there a better way？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org