[jira] [Commented] (FLINK-1724) TestingCluster uses local communication with multiple task managers

["Stephan Ewen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14367140#comment-14367140 ] 

Stephan Ewen commented on FLINK-1724:
-------------------------------------

I think that there is actually too much too diverse code to start a TaskManager and a JobManager like this and like that. It makes the tests also hard to read.

Starting a TaskManager directly with a configuration is very simple, and explicit and easy to understand (for someone reading tests). I vote to use this mechanism more, rather than having three different utils that start them differently.

> TestingCluster uses local communication with multiple task managers
> -------------------------------------------------------------------
>
>                 Key: FLINK-1724
>                 URL: https://issues.apache.org/jira/browse/FLINK-1724
>             Project: Flink
>          Issue Type: Bug
>    Affects Versions: master
>            Reporter: Ufuk Celebi
>            Priority: Minor
>
> Starting a task manager via TestingUtils does not respect the number of configured task managers and mis-configures the task managers to use local network communication (LocalConnectionManager instead of NettyConnectionManager).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)