You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/02/28 09:27:38 UTC
[GitHub] [incubator-pekko-grpc] mdedetrich opened a new pull request, #34: Remove pekko-grpc prefix from project ids
mdedetrich opened a new pull request, #34:
URL: https://github.com/apache/incubator-pekko-grpc/pull/34
tbd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #34: Remove pekko-grpc prefix from project ids
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #34:
URL: https://github.com/apache/incubator-pekko-grpc/pull/34#discussion_r1119885104
##########
build.sbt:
##########
@@ -166,19 +173,20 @@ lazy val benchmarks = Project(id = "benchmarks", base = file("benchmarks"))
.enablePlugins(JmhPlugin)
.disablePlugins(MimaPlugin)
.settings(
+ name := s"$pekkoPrefix-benchmarks",
crossScalaVersions := Dependencies.Versions.CrossScalaForLib,
scalaVersion := Dependencies.Versions.CrossScalaForLib.head,
(publish / skip) := true)
.settings(MetaInfLicenseNoticeCopy.settings)
-lazy val docs = Project(id = "pekko-grpc-docs", base = file("docs"))
+lazy val docs = Project(id = "docs", base = file("docs"))
// Make sure code generation is run:
.dependsOn(pluginTesterScala)
.dependsOn(pluginTesterJava)
.enablePlugins(AkkaParadoxPlugin, ParadoxSitePlugin, PreprocessPlugin, PublishRsyncPlugin)
.disablePlugins(MimaPlugin)
.settings(
- name := "Apache Pekko gRPC",
+ name := s"$pekkoPrefix-docs",
Review Comment:
While the `name` here is irrelevant, its highly misleading and also quite different to the rest of the pekko projects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich merged pull request #34: Remove pekko-grpc prefix from project ids
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #34:
URL: https://github.com/apache/incubator-pekko-grpc/pull/34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #34: Remove pekko-grpc prefix from project ids
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #34:
URL: https://github.com/apache/incubator-pekko-grpc/pull/34#discussion_r1119885396
##########
build.sbt:
##########
@@ -166,19 +173,20 @@ lazy val benchmarks = Project(id = "benchmarks", base = file("benchmarks"))
.enablePlugins(JmhPlugin)
.disablePlugins(MimaPlugin)
.settings(
+ name := s"$pekkoPrefix-benchmarks",
crossScalaVersions := Dependencies.Versions.CrossScalaForLib,
scalaVersion := Dependencies.Versions.CrossScalaForLib.head,
(publish / skip) := true)
.settings(MetaInfLicenseNoticeCopy.settings)
-lazy val docs = Project(id = "pekko-grpc-docs", base = file("docs"))
+lazy val docs = Project(id = "docs", base = file("docs"))
// Make sure code generation is run:
.dependsOn(pluginTesterScala)
.dependsOn(pluginTesterJava)
.enablePlugins(AkkaParadoxPlugin, ParadoxSitePlugin, PreprocessPlugin, PublishRsyncPlugin)
.disablePlugins(MimaPlugin)
.settings(
- name := "Apache Pekko gRPC",
Review Comment:
While the `name` here is irrelevant, its highly misleading and also different to the rest of the pekko projects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #34: Remove pekko-grpc prefix from project ids
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #34:
URL: https://github.com/apache/incubator-pekko-grpc/pull/34#discussion_r1119885396
##########
build.sbt:
##########
@@ -166,19 +173,20 @@ lazy val benchmarks = Project(id = "benchmarks", base = file("benchmarks"))
.enablePlugins(JmhPlugin)
.disablePlugins(MimaPlugin)
.settings(
+ name := s"$pekkoPrefix-benchmarks",
crossScalaVersions := Dependencies.Versions.CrossScalaForLib,
scalaVersion := Dependencies.Versions.CrossScalaForLib.head,
(publish / skip) := true)
.settings(MetaInfLicenseNoticeCopy.settings)
-lazy val docs = Project(id = "pekko-grpc-docs", base = file("docs"))
+lazy val docs = Project(id = "docs", base = file("docs"))
// Make sure code generation is run:
.dependsOn(pluginTesterScala)
.dependsOn(pluginTesterJava)
.enablePlugins(AkkaParadoxPlugin, ParadoxSitePlugin, PreprocessPlugin, PublishRsyncPlugin)
.disablePlugins(MimaPlugin)
.settings(
- name := "Apache Pekko gRPC",
Review Comment:
While the `name` here is irrelevant, its highly misleading and also quite different to the rest of the pekko projects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org