You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Lars George (JIRA)" <ji...@apache.org> on 2007/07/14 01:25:04 UTC
[jira] Created: (HTTPCLIENT-665) Change access to internal maps of
HttpState to protected.
Change access to internal maps of HttpState to protected.
---------------------------------------------------------
Key: HTTPCLIENT-665
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-665
Project: HttpComponents HttpClient
Issue Type: Improvement
Components: HttpClient
Affects Versions: 3.0 Final
Reporter: Lars George
Priority: Trivial
To be able to serialize the conversational state of a http session access to the internal maps of HttpState is required. Currently they are all "private", so subclasses cannot access them. Changing the access to "protected" will allow any subclass to access those maps.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Commented: (HTTPCLIENT-665) Change access to internal maps
of HttpState to protected.
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516471 ]
Oleg Kalnichevski commented on HTTPCLIENT-665:
----------------------------------------------
Looks good to me
Oleg
> Change access to internal maps of HttpState to protected.
> ---------------------------------------------------------
>
> Key: HTTPCLIENT-665
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-665
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Affects Versions: 3.0 Final
> Reporter: Lars George
> Priority: Trivial
> Fix For: 3.1 Final
>
> Attachments: 2k7-07-30-HttpState-665.txt
>
>
> To be able to serialize the conversational state of a http session access to the internal maps of HttpState is required. Currently they are all "private", so subclasses cannot access them. Changing the access to "protected" will allow any subclass to access those maps.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Closed: (HTTPCLIENT-665) Change access to internal maps of
HttpState to protected.
Posted by "Roland Weber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roland Weber closed HTTPCLIENT-665.
-----------------------------------
Resolution: Fixed
> Change access to internal maps of HttpState to protected.
> ---------------------------------------------------------
>
> Key: HTTPCLIENT-665
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-665
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Affects Versions: 3.0 Final
> Reporter: Lars George
> Priority: Trivial
> Fix For: 3.1 Final
>
> Attachments: 2k7-07-30-HttpState-665.txt
>
>
> To be able to serialize the conversational state of a http session access to the internal maps of HttpState is required. Currently they are all "private", so subclasses cannot access them. Changing the access to "protected" will allow any subclass to access those maps.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Updated: (HTTPCLIENT-665) Change access to internal maps of
HttpState to protected.
Posted by "Roland Weber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roland Weber updated HTTPCLIENT-665:
------------------------------------
Attachment: 2k7-07-30-HttpState-665.txt
Here's a patch that changes both credential maps and the cookie list to protected.
For the other attributes, there are getter and setter methods available.
cheers,
Roland
> Change access to internal maps of HttpState to protected.
> ---------------------------------------------------------
>
> Key: HTTPCLIENT-665
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-665
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Affects Versions: 3.0 Final
> Reporter: Lars George
> Priority: Trivial
> Fix For: 3.1 Final
>
> Attachments: 2k7-07-30-HttpState-665.txt
>
>
> To be able to serialize the conversational state of a http session access to the internal maps of HttpState is required. Currently they are all "private", so subclasses cannot access them. Changing the access to "protected" will allow any subclass to access those maps.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Updated: (HTTPCLIENT-665) Change access to internal maps of
HttpState to protected.
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski updated HTTPCLIENT-665:
-----------------------------------------
Fix Version/s: 3.1 Final
> Change access to internal maps of HttpState to protected.
> ---------------------------------------------------------
>
> Key: HTTPCLIENT-665
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-665
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Affects Versions: 3.0 Final
> Reporter: Lars George
> Priority: Trivial
> Fix For: 3.1 Final
>
>
> To be able to serialize the conversational state of a http session access to the internal maps of HttpState is required. Currently they are all "private", so subclasses cannot access them. Changing the access to "protected" will allow any subclass to access those maps.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Commented: (HTTPCLIENT-665) Change access to internal maps
of HttpState to protected.
Posted by "Roland Weber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512785 ]
Roland Weber commented on HTTPCLIENT-665:
-----------------------------------------
Changing attribute visibility in HttpState will only affect applications that extend this class and use the same attribute names.
If I am not mistaken, Java allows re-use of attribute names in derived classes, and scoping will make sure that the behavior remains the same as it is now.
If there are problems with name clashes, the workaround is to rename the attributes in the derived classes.
Based on the non-impact on existing applications, I am in favor of this change.
cheers,
Roland
> Change access to internal maps of HttpState to protected.
> ---------------------------------------------------------
>
> Key: HTTPCLIENT-665
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-665
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Affects Versions: 3.0 Final
> Reporter: Lars George
> Priority: Trivial
>
> To be able to serialize the conversational state of a http session access to the internal maps of HttpState is required. Currently they are all "private", so subclasses cannot access them. Changing the access to "protected" will allow any subclass to access those maps.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org