You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "Dmitry Murashenkov (JIRA)" <ji...@apache.org> on 2009/08/22 13:13:14 UTC

[jira] Created: (OPENEJB-1062) StickyConnectionStrategy incorrectly caches connections

StickyConnectionStrategy incorrectly caches connections
-------------------------------------------------------

                 Key: OPENEJB-1062
                 URL: https://issues.apache.org/jira/browse/OPENEJB-1062
             Project: OpenEJB
          Issue Type: Bug
          Components: connectors
    Affects Versions: 3.1.1
            Reporter: Dmitry Murashenkov
            Priority: Blocker


Test case:

1. Create InitialContext (instance A) that connects to server 1. Lookup some bean there.
2. Create another InitialContext (instance B) that connects to server 2.

In fact on the step 2 InitialContext instance B is connected to server 1. Because of the following lines in the StickyConnectionStrategy:

if (null != lastLocation && !failed.contains(lastLocation)) {
    return connect(lastLocation); 
}

There is no check that server.getLocation() is equal to lastLocation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (OPENEJB-1062) StickyConnectionStrategy incorrectly caches connections

Posted by "David Blevins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Blevins closed OPENEJB-1062.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 3.1.2
         Assignee: David Blevins

$ svn ci server
Sending        server/openejb-client/src/main/java/org/apache/openejb/client/ClusterMetaData.java
Sending        server/openejb-client/src/main/java/org/apache/openejb/client/ClusterResponse.java
Sending        server/openejb-client/src/main/java/org/apache/openejb/client/JNDIContext.java
Sending        server/openejb-client/src/main/java/org/apache/openejb/client/StickyConnectionStrategy.java
Sending        server/openejb-client/src/test/java/org/apache/openejb/client/MainTest.java
Adding         server/openejb-client/src/test/java/org/apache/openejb/client/OverlyStickyConnectionTest.java
Transmitting file data ......
Committed revision 813292.


> StickyConnectionStrategy incorrectly caches connections
> -------------------------------------------------------
>
>                 Key: OPENEJB-1062
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1062
>             Project: OpenEJB
>          Issue Type: Bug
>          Components: connectors
>    Affects Versions: 3.1.1
>            Reporter: Dmitry Murashenkov
>            Assignee: David Blevins
>            Priority: Blocker
>             Fix For: 3.1.2
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Test case:
> 1. Create InitialContext (instance A) that connects to server 1. Lookup some bean there.
> 2. Create another InitialContext (instance B) that connects to server 2.
> In fact on the step 2 InitialContext instance B is connected to server 1. Because of the following lines in the StickyConnectionStrategy:
> if (null != lastLocation && !failed.contains(lastLocation)) {
>     return connect(lastLocation); 
> }
> There is no check that server.getLocation() is equal to lastLocation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.