You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "BiteTheDDDDt (via GitHub)" <gi...@apache.org> on 2024/01/31 13:05:19 UTC
[PR] [Improvement](exec) fix wrong profile on distinct agg and pass reference on uint136's com… [doris]
BiteTheDDDDt opened a new pull request, #30661:
URL: https://github.com/apache/doris/pull/30661
…pare
## Proposed changes
fix wrong profile on distinct agg and pass reference on uint136's compare
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improvement](exec) fix wrong profile on distinct agg and pass reference on uint136's com… [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #30661:
URL: https://github.com/apache/doris/pull/30661#issuecomment-1919068054
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improvement](exec) fix wrong profile on distinct agg and pass reference on uint136's com… [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #30661:
URL: https://github.com/apache/doris/pull/30661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improvement](exec) fix wrong profile on distinct agg and pass reference on uint136's com… [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30661:
URL: https://github.com/apache/doris/pull/30661#issuecomment-1919078650
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improvement](exec) fix wrong profile on distinct agg and pass reference on uint136's com… [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30661:
URL: https://github.com/apache/doris/pull/30661#issuecomment-1919078600
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improvement](exec) fix wrong profile on distinct agg and pass reference on uint136's com… [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30661:
URL: https://github.com/apache/doris/pull/30661#issuecomment-1919083995
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improvement](exec) fix wrong profile on distinct agg and pass reference on uint136's com… [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30661:
URL: https://github.com/apache/doris/pull/30661#issuecomment-1919214355
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 4e3f691159549631648309357fb6679cf17e8a04 with default session variables
Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 13.4 seconds inserted 10000000 Rows, about 746K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improvement](exec) fix wrong profile on distinct agg and pass reference on uint136's com… [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30661:
URL: https://github.com/apache/doris/pull/30661#issuecomment-1919176271
<details>
<summary>TPC-H: <b>Total hot run time: 36886 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4e3f691159549631648309357fb6679cf17e8a04, data reload: false
------ Round 1 ----------------------------------
q1 17666 4503 4439 4439
q2 2048 138 128 128
q3 10603 895 950 895
q4 4646 680 703 680
q5 7668 2787 2807 2787
q6 185 124 123 123
q7 1155 726 705 705
q8 9253 2006 2014 2006
q9 7255 6366 6315 6315
q10 8086 2467 2431 2431
q11 415 215 204 204
q12 761 283 269 269
q13 18040 3314 3326 3314
q14 280 249 241 241
q15 538 496 500 496
q16 457 405 407 405
q17 943 526 495 495
q18 6989 6054 5913 5913
q19 1582 1372 1452 1372
q20 583 346 317 317
q21 7017 3055 3072 3055
q22 814 306 296 296
Total cold run time: 106984 ms
Total hot run time: 36886 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4476 4436 4460 4436
q2 348 233 224 224
q3 2952 2845 2829 2829
q4 1818 1643 1617 1617
q5 5206 5214 5251 5214
q6 189 114 117 114
q7 2182 1764 1773 1764
q8 3140 3259 3302 3259
q9 8417 8332 8324 8324
q10 5823 3594 3584 3584
q11 543 447 472 447
q12 741 560 567 560
q13 11367 3094 3071 3071
q14 281 260 254 254
q15 523 489 493 489
q16 521 451 448 448
q17 1844 1688 1672 1672
q18 8172 7793 7595 7595
q19 10705 1561 1558 1558
q20 2135 1913 1893 1893
q21 4805 4545 4581 4545
q22 557 443 476 443
Total cold run time: 76745 ms
Total hot run time: 54340 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improvement](exec) fix wrong profile on distinct agg and pass reference on uint136's com… [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30661:
URL: https://github.com/apache/doris/pull/30661#issuecomment-1919208385
<details>
<summary>ClickBench: <b>Total hot run time: 31.35 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4e3f691159549631648309357fb6679cf17e8a04, data reload: false
query1 0.03 0.03 0.02
query2 0.06 0.02 0.02
query3 0.23 0.06 0.06
query4 1.66 0.10 0.09
query5 0.52 0.52 0.52
query6 1.18 0.65 0.63
query7 0.02 0.02 0.01
query8 0.04 0.03 0.03
query9 0.55 0.49 0.50
query10 0.58 0.56 0.56
query11 0.12 0.09 0.08
query12 0.11 0.09 0.10
query13 0.60 0.60 0.61
query14 0.79 0.79 0.81
query15 0.79 0.78 0.77
query16 0.38 0.38 0.39
query17 1.03 1.04 0.98
query18 0.23 0.27 0.24
query19 1.90 1.79 1.78
query20 0.01 0.02 0.02
query21 15.40 0.57 0.59
query22 2.79 2.42 2.21
query23 17.31 0.76 0.70
query24 2.50 1.35 1.17
query25 0.37 0.16 0.13
query26 0.65 0.14 0.14
query27 0.04 0.05 0.06
query28 11.36 0.84 0.81
query29 12.67 3.23 3.09
query30 0.64 0.54 0.54
query31 2.79 0.35 0.35
query32 3.36 0.48 0.49
query33 3.23 3.15 3.27
query34 15.88 4.30 4.27
query35 4.33 4.23 4.39
query36 1.09 1.06 1.05
query37 0.06 0.04 0.04
query38 0.03 0.03 0.03
query39 0.03 0.01 0.02
query40 0.17 0.13 0.13
query41 0.07 0.02 0.01
query42 0.02 0.02 0.01
query43 0.03 0.02 0.02
Total cold run time: 105.65 s
Total hot run time: 31.35 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improvement](exec) fix wrong profile on distinct agg and pass reference on uint136's com… [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30661:
URL: https://github.com/apache/doris/pull/30661#issuecomment-1919067865
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improvement](exec) fix wrong profile on distinct agg and pass reference on uint136's com… [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30661:
URL: https://github.com/apache/doris/pull/30661#issuecomment-1919198065
<details>
<summary>TPC-DS: <b>Total hot run time: 174602 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4e3f691159549631648309357fb6679cf17e8a04, data reload: false
query1 921 332 329 329
query2 6606 1987 1855 1855
query3 6700 212 206 206
query4 31697 22072 22044 22044
query5 4451 348 364 348
query6 244 154 162 154
query7 4608 255 260 255
query8 238 173 176 173
query9 9207 2242 2233 2233
query10 411 195 204 195
query11 18178 15268 15241 15241
query12 119 67 63 63
query13 1612 377 369 369
query14 10170 7627 7220 7220
query15 242 169 180 169
query16 7385 269 251 251
query17 1846 481 467 467
query18 1933 255 250 250
query19 348 137 136 136
query20 74 65 71 65
query21 197 136 130 130
query22 4697 4760 4534 4534
query23 30976 30214 30256 30214
query24 6411 2695 2768 2695
query25 488 316 303 303
query26 716 136 134 134
query27 1934 284 285 284
query28 3570 1842 1833 1833
query29 907 604 598 598
query30 261 133 135 133
query31 926 704 711 704
query32 89 56 50 50
query33 426 211 218 211
query34 826 447 461 447
query35 838 757 743 743
query36 1319 1156 1209 1156
query37 92 65 57 57
query38 3321 3124 3146 3124
query39 1300 1252 1261 1252
query40 200 85 93 85
query41 36 34 33 33
query42 90 81 80 80
query43 496 481 464 464
query44 1029 682 696 682
query45 195 181 172 172
query46 1040 640 625 625
query47 1548 1508 1514 1508
query48 382 318 300 300
query49 818 277 270 270
query50 681 307 301 301
query51 5284 5173 5144 5144
query52 89 76 76 76
query53 321 259 260 259
query54 232 182 202 182
query55 76 80 79 79
query56 170 156 155 155
query57 952 914 902 902
query58 182 155 156 155
query59 2369 2335 2304 2304
query60 211 183 166 166
query61 87 85 88 85
query62 508 364 371 364
query63 275 259 257 257
query64 4295 3696 3368 3368
query65 3247 3230 3232 3230
query66 950 325 305 305
query67 14603 14296 14210 14210
query68 3972 490 499 490
query69 448 311 308 308
query70 1546 1433 1501 1433
query71 299 216 210 210
query72 5365 3099 2843 2843
query73 680 315 321 315
query74 6624 6212 6275 6212
query75 2904 2241 2309 2241
query76 2521 958 924 924
query77 389 237 230 230
query78 9212 8877 8553 8553
query79 2935 499 482 482
query80 2167 322 306 306
query81 510 190 200 190
query82 793 78 83 78
query83 258 120 121 120
query84 284 79 72 72
query85 2002 348 333 333
query86 502 389 392 389
query87 3462 3265 3250 3250
query88 3983 2253 2237 2237
query89 435 344 355 344
query90 1976 190 187 187
query91 154 119 116 116
query92 55 44 42 42
query93 4570 447 407 407
query94 1393 159 158 158
query95 498 459 445 445
query96 659 318 323 318
query97 4225 4121 4115 4115
query98 213 187 185 185
query99 1185 685 683 683
Total cold run time: 272869 ms
Total hot run time: 174602 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improvement](exec) fix wrong profile on distinct agg and pass reference on uint136's com… [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30661:
URL: https://github.com/apache/doris/pull/30661#issuecomment-1919206726
TeamCity be ut coverage result:
Function Coverage: 36.18% (8626/23842)
Line Coverage: 28.24% (70541/249757)
Region Coverage: 27.25% (36401/133600)
Branch Coverage: 24.03% (18643/77580)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4e3f691159549631648309357fb6679cf17e8a04_4e3f691159549631648309357fb6679cf17e8a04/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org