[GitHub] [ignite] anton-vinogradov commented on a change in pull request #7091: IGNITE-12406 Refactor GridCommonAbstractTest#findKeys to use enum

[GitBox <gi...@apache.org>]

anton-vinogradov commented on a change in pull request #7091: IGNITE-12406 Refactor GridCommonAbstractTest#findKeys to use enum
URL: https://github.com/apache/ignite/pull/7091#discussion_r352429127
 
 

 ##########
 File path: modules/core/src/test/java/org/apache/ignite/testframework/junits/common/KeyType.java
 ##########
 @@ -0,0 +1,20 @@
+package org.apache.ignite.testframework.junits.common;
+
+/**
+ * Defined type of key
+ * */
+public enum KeyType {
+    PRIMARY(0),
 
 Review comment:
   We should provide solutions as small/simple as possible.
   In case you're not required this now, code should not contain this.
   For every code fragment at PR, you should be able to provide proper explanation"why it's here", "good practice" is not acceptable explanation.
   
   BTW, `keyType.getKeyIndex() * 100_00` looks odd to me, can we refactor this to?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services