[GitHub] [beam] udim commented on a change in pull request #15693: [BEAM-12985] Call pytest directly rather than run_pytest.sh to avoid running pyarrow tests twice

[GitBox <gi...@apache.org>]

udim commented on a change in pull request #15693:
URL: https://github.com/apache/beam/pull/15693#discussion_r725168238



##########
File path: sdks/python/tox.ini
##########
@@ -247,5 +247,6 @@ deps =
 commands =
   # Log pyarrow and numpy version for debugging
   /bin/sh -c "pip freeze | grep -E '(pyarrow|numpy)'"
-  # TODO(BEAM-12985): Running run_pytest.sh with -m causes us to run all the tests twice
-  {toxinidir}/scripts/run_pytest.sh {envname} "{posargs}" '-m uses_pyarrow'
+  # Run pytest directly rather using run_pytest.sh. It doesn't handle
+  # selecting tests with -m (BEAM-12985)
+  pytest -o junit_suite_name={envname} --junitxml=pytest_{envname}.xml -n 6 -m uses_pyarrow

Review comment:
       Nit: consider adding `{posargs}` to the end of this line. It might not be super useful in this case because I'm guessing this runs quickly, but it allows to pass additional arguments to pytest (as in: `tox -e py38-pyarrow-5 -- -k my_test`).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org