You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ossie.apache.org by "MahmoudHassanen99 (via GitHub)" <gi...@apache.org> on 2026/10/10 19:35:58 UTC
[PR] feat(core-spec): add CLICKHOUSE to Dialect enum (#546) [ossie]
MahmoudHassanen99 opened a new pull request, #558:
URL: https://github.com/apache/ossie/pull/558
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
## Summary
Adds `CLICKHOUSE` to the `Dialect` enum across `core-spec/spec.md`, `core-spec/ossie-schema.json`, and `core-spec/spec.yaml`. This officially registers ClickHouse as a supported expression language dialect in the Apache Ossie specification, allowing semantic models targeting ClickHouse SQL expressions to pass core schema validation.
## Related Issues
Refers to #546
## Checklist
### Specification
- [x] Spec changes are included in `core-spec/` and follow the existing structure
- [x] Spec changes have been discussed on the mailing list or in a linked issue
- [ ] Breaking changes to the spec are clearly called out in the summary
### Ontology
- [ ] Ontology changes in `ontology/` are consistent with spec changes
- [ ] New or modified terms are defined and documented
### Converters
- [ ] Converter logic in `converters/` is updated to reflect spec or ontology changes
- [ ] New converters include tests under the converter's test directory
- [ ] If adding a new converter, `.github/labeler.yml` is updated with the new path
### Validation
- [ ] Validation rules in `validation/` are updated if the spec changed
- [ ] New validation cases are covered by tests
### Documentation
- [ ] `docs/` is updated to reflect any user-facing changes
- [ ] New features or behaviors are documented with examples where appropriate
- [ ] `CONTRIBUTING.md` is updated if the contribution process changed
### Examples
- [ ] `examples/` are added or updated for any new spec constructs or converter support
### Tests
- [x] All existing tests pass (`pytest` / CI green)
- [ ] New functionality is covered by tests
### Compliance
- [x] ASF license headers are present on all new source files
- [x] No third-party dependencies are added without PMC/IPMC approval
- [ ] If third-party source code is vendored/copied (not just declared as a dependency), `NOTICE` and/or `LICENSE` have been updated per [ASF policy](https://infra.apache.org/licensing-howto.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core-spec): add CLICKHOUSE to Dialect enum (#546) [ossie]
Posted by "kayemkim (via GitHub)" <gi...@apache.org>.
kayemkim commented on PR #558:
URL: https://github.com/apache/ossie/pull/558#issuecomment-6117669896
Two of the checks that run on a `core-spec/**` change fail on this branch as it stands.
`python-ci` runs `test_dialect_enum_matches_core_schema` in `python/tests/test_models.py`, which asserts that `OssieDialect` in `python/src/ossie/models.py` has the same members as the schema enum, so `CLICKHOUSE` needs a line there too. The same test runs again in `validation-ci`'s shared Python model tests.
`validation-ci`'s spec.yaml sync step runs `scripts/generate-spec-types.py --check`, and that stops with `no description for 'dialects' value 'CLICKHOUSE'` until the `dialects` descriptions map in `SECTIONS` gets an entry. The script renders that block from the map and diffs it against spec.yaml, so with `"CLICKHOUSE": "ClickHouse SQL"` the line you already added matches what it writes.
#538 added `HOLISTICS_AQL` across the same five files, if you want a diff to follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core-spec): add CLICKHOUSE to Dialect enum (#546) [ossie]
Posted by "MahmoudHassanen99 (via GitHub)" <gi...@apache.org>.
MahmoudHassanen99 commented on PR #558:
URL: https://github.com/apache/ossie/pull/558#issuecomment-6126072885
Thanks @kayemkim for your supporr
I updated models.py and scripts/generate-spec-types.py with CLICKHOUSE.
CI checks are re-running now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core-spec): add CLICKHOUSE to Dialect enum (#546) [ossie]
Posted by "kayemkim (via GitHub)" <gi...@apache.org>.
kayemkim commented on PR #558:
URL: https://github.com/apache/ossie/pull/558#issuecomment-6266784846
One more thing will show up when you rebase. #612 adds tests that compare `DIALECT_MAP` in `validation/validate.py` and the Holistics tables in `converters/holistics/src/ossie_holistics/sqlrefs.py` with the schema enum, and JB plans to merge it ahead of the dialect PRs. On this branch merged onto it, both fail on `CLICKHOUSE`: it needs `"CLICKHOUSE": "clickhouse"` in `DIALECT_MAP`, which is the name sqlglot uses, and the same line in `SQLGLOT_DIALECT`. The hex converter also wants the entry in `_DIALECT_NAME_MAP`, a branch in `_to_sqlglot_dialect` and the CLI snapshot update, as #598 did for its two dialects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core-spec): add CLICKHOUSE to Dialect enum (#546) [ossie]
Posted by "MahmoudHassanen99 (via GitHub)" <gi...@apache.org>.
MahmoudHassanen99 commented on PR #558:
URL: https://github.com/apache/ossie/pull/558#issuecomment-6384598280
Thanks @kayemkim for the helpful guidance!
I've rebased onto main and added "CLICKHOUSE": "clickhouse" to DIALECT_MAP in validation/validate.py. With all 6 core files updated (ossie-schema.json, spec.yaml, spec.md, models.py, generate-spec-types.py, and validate.py), all 507 tests in pytest are passing cleanly locally.
I'll proceed to the apache/ossie-converters repository next to add the ClickHouse dialect mappings across the Hex and Holistics converters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org