You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Kevin Klues (JIRA)" <ji...@apache.org> on 2018/02/07 15:17:00 UTC
[jira] [Commented] (MESOS-7310) Implement a separate python client
library for the new cli
[ https://issues.apache.org/jira/browse/MESOS-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355574#comment-16355574 ]
Kevin Klues commented on MESOS-7310:
------------------------------------
{noformat}
commit 6906310e568355724933503c85a7248ce8cf641d
Author: Eric Chung <ci...@gmail.com>
Date: Wed Feb 7 15:49:32 2018 +0100
Added extra python package requirements for the new python-based CLI.
These extra python packages will be used by subsequent commits.
Review: https://reviews.apache.org/r/61172/
{noformat}
{noformat}
commit 9571adc9ac87873bf7688eefcb315d4141f4b3e1
Author: Eric Chung <ci...@gmail.com>
Date: Wed Feb 7 15:52:56 2018 +0100
Whitelisted the 'ujson' package for linting in the new python-based CLI.
The 'usjon' package contains C-bindings which break the python linter
when imported into our CLI python modules. This commit whitelists this
package for the linter so that we can import it without linting errors.
Review: https://reviews.apache.org/r/61172/
{noformat}
{noformat}
commit dea1b31ec6ac466831095d82e280911365d2f174
Author: Eric Chung <ci...@gmail.com>
Date: Wed Feb 7 16:01:08 2018 +0100
Updated the python-based CLIs tox.ini file.
This file has been updated to pull in its python dependencies directly
from the relevant requirements.txt and requirements-test.txt files
instead of duplicating the list of packages from these files.
Review: https://reviews.apache.org/r/61172/
{noformat}
{noformat}
commit 994213739b1afc473bbd9d15ded7c3fd26eaa924 (HEAD -> master, upstream/master, origin/master)
Author: Eric Chung <ci...@gmail.com>
Date: Wed Feb 7 16:02:17 2018 +0100
Added 'mesos.http' and 'mesos.exceptions' for the python-based CLI.
Part of MESOS-7310, this patch adds the mesos.http and mesos.exceptions
modules, which provides a Resource class and its descendants for
abstracting away common operations over http connections with JSON
serialization.
Review: https://reviews.apache.org/r/61172/
{noformat}
> Implement a separate python client library for the new cli
> ----------------------------------------------------------
>
> Key: MESOS-7310
> URL: https://issues.apache.org/jira/browse/MESOS-7310
> Project: Mesos
> Issue Type: Task
> Components: cli
> Affects Versions: 1.3.0
> Reporter: Eric Chung
> Assignee: Eric Chung
> Priority: Major
>
> cli_new in its current form is very difficult to package due to the following reasons:
> 1. src/cli_new/lib/mesos imports plugins using relative imports, which fails if it is built into a pip package
> 2. there is no setup.py script which defines what should be installed
> 3. plugins/tests are unnecessarily included in the package, which are things consumers of the package shouldn’t be able to import
> having such a package will allow external consumers to be able to add application-specific wrappers on it, e.g. integration with ACL libraries of their choice.
> The plan as discussed will create a `mesos` package under `src/python/lib`, potentially including a `setup.py` for building the package into a PyPI package.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)