You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/01/26 09:34:41 UTC
[GitHub] [incubator-mxnet] anko-intel opened a new pull request #20848: [BUGFIX] Fix issue with LogMessageFatal
anko-intel opened a new pull request #20848:
URL: https://github.com/apache/incubator-mxnet/pull/20848
## Description ##
There were two different versions of the LogMessageFatal class in the
same namespace in different files so depending on order of compilation
it sometimes cause mixing it and segmentation fault (probably due to
mixing versions of constructor/destructor (one inlined and one linked))
It is connected with the issue reported on v1.x branch: https://github.com/apache/incubator-mxnet/issues/20827
## Checklist ##
### Essentials ###
- [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [ ] Code is well-documented
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on pull request #20848: [BUGFIX] Fix issue with LogMessageFatal
Posted by GitBox <gi...@apache.org>.
anko-intel commented on pull request #20848:
URL: https://github.com/apache/incubator-mxnet/pull/20848#issuecomment-1022085578
> @anko-intel: Why are these files modified here?
3rdparty/mshadow is no git module any longer. The other words it is not real 3rparty now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20848: [BUGFIX] Fix issue with LogMessageFatal
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20848:
URL: https://github.com/apache/incubator-mxnet/pull/20848#issuecomment-1022282611
Jenkins CI successfully triggered : [centos-cpu, centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20848: [BUGFIX] Fix issue with LogMessageFatal
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20848:
URL: https://github.com/apache/incubator-mxnet/pull/20848#issuecomment-1022022468
Hey @anko-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [edge, unix-cpu, windows-gpu, miscellaneous, website, centos-gpu, windows-cpu, sanity, unix-gpu, centos-cpu, clang]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on pull request #20848: [BUGFIX] Fix issue with LogMessageFatal
Posted by GitBox <gi...@apache.org>.
anko-intel commented on pull request #20848:
URL: https://github.com/apache/incubator-mxnet/pull/20848#issuecomment-1022282495
@mxnet-bot run ci [centos-gpu, centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] josephevans merged pull request #20848: [BUGFIX] Fix issue with LogMessageFatal
Posted by GitBox <gi...@apache.org>.
josephevans merged pull request #20848:
URL: https://github.com/apache/incubator-mxnet/pull/20848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on a change in pull request #20848: [BUGFIX] Fix issue with LogMessageFatal
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on a change in pull request #20848:
URL: https://github.com/apache/incubator-mxnet/pull/20848#discussion_r792487052
##########
File path: 3rdparty/mshadow/mshadow/base.h
##########
@@ -314,7 +314,7 @@ MSHADOW_HALF_BF_OPERATOR(bool, >=)
/*! \brief overloaded <= operator between half_t and bf16_t */
MSHADOW_HALF_BF_OPERATOR(bool, <=)
-#include "./logging.h"
Review comment:
@anko-intel: Why are you modifying these files here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on a change in pull request #20848: [BUGFIX] Fix issue with LogMessageFatal
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on a change in pull request #20848:
URL: https://github.com/apache/incubator-mxnet/pull/20848#discussion_r792487052
##########
File path: 3rdparty/mshadow/mshadow/base.h
##########
@@ -314,7 +314,7 @@ MSHADOW_HALF_BF_OPERATOR(bool, >=)
/*! \brief overloaded <= operator between half_t and bf16_t */
MSHADOW_HALF_BF_OPERATOR(bool, <=)
-#include "./logging.h"
Review comment:
@anko-intel: Why are you modifying these files here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org