[GitHub] [cloudstack] ravening commented on a change in pull request #4078: Cleanup download urls when SSVM destroyed

[GitBox <gi...@apache.org>]

ravening commented on a change in pull request #4078:
URL: https://github.com/apache/cloudstack/pull/4078#discussion_r426501969



##########
File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java
##########
@@ -3237,13 +3245,29 @@ protected void runInContext() {
         }
     }
 
+    private void cleanupDownloadUrls(VMInstanceVO systemVm) {

Review comment:
       Yes but I didnt pass it purposefully because in case in future we need to do further processing with the systemvm, we will have entire data. If I just pass data center id, we dont have reference to systemvm




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org