You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by pa...@gmail.com on 2011/10/05 23:07:07 UTC
Review Request: OOZIE-573: error message about misconfig in starting time of
coordinator and initial-instance of dataset
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2225/
-----------------------------------------------------------
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Summary
-------
OOZIE-573: error message about misconfig in starting time of coordinator and initial-instance of dataset
Summary:
https://issues.apache.org/jira/browse/OOZIE-573
This addresses bug OOZIE-573.
https://issues.apache.org/jira/browse/OOZIE-573
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 1179437
trunk/release-log.txt 1179437
Diff: https://reviews.apache.org/r/2225/diff
Testing
-------
Tested against current test cases.
Thanks,
params
Re: Review Request: OOZIE-573: error message about misconfig in starting
time of coordinator and initial-instance of dataset
Posted by "Angelo K. Huang" <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2225/#review2367
-----------------------------------------------------------
+1
- Angelo K.
On 2011-10-05 21:07:07, params wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2225/
> -----------------------------------------------------------
>
> (Updated 2011-10-05 21:07:07)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> OOZIE-573: error message about misconfig in starting time of coordinator and initial-instance of dataset
>
> Summary:
> https://issues.apache.org/jira/browse/OOZIE-573
>
>
> This addresses bug OOZIE-573.
> https://issues.apache.org/jira/browse/OOZIE-573
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 1179437
> trunk/release-log.txt 1179437
>
> Diff: https://reviews.apache.org/r/2225/diff
>
>
> Testing
> -------
>
> Tested against current test cases.
>
>
> Thanks,
>
> params
>
>
Re: Review Request: OOZIE-573: error message about misconfig in starting
time of coordinator and initial-instance of dataset
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2225/#review2627
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
<https://reviews.apache.org/r/2225/#comment5934>
Please replace 'n' with exact value.
- Mohammad
On 2011-10-14 22:31:28, params wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2225/
> -----------------------------------------------------------
>
> (Updated 2011-10-14 22:31:28)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> OOZIE-573: error message about misconfig in starting time of coordinator and initial-instance of dataset
>
> Summary:
> https://issues.apache.org/jira/browse/OOZIE-573
>
>
> This addresses bug OOZIE-573.
> https://issues.apache.org/jira/browse/OOZIE-573
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 1182589
>
> Diff: https://reviews.apache.org/r/2225/diff
>
>
> Testing
> -------
>
> Tested against current test cases.
>
>
> Thanks,
>
> params
>
>
Re: Review Request: OOZIE-573: error message about misconfig in starting
time of coordinator and initial-instance of dataset
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2225/#review2634
-----------------------------------------------------------
+1. Committed.
- Mohammad
On 2011-10-17 21:24:33, params wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2225/
> -----------------------------------------------------------
>
> (Updated 2011-10-17 21:24:33)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> OOZIE-573: error message about misconfig in starting time of coordinator and initial-instance of dataset
>
> Summary:
> https://issues.apache.org/jira/browse/OOZIE-573
>
>
> This addresses bug OOZIE-573.
> https://issues.apache.org/jira/browse/OOZIE-573
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 1185323
>
> Diff: https://reviews.apache.org/r/2225/diff
>
>
> Testing
> -------
>
> Tested against current test cases.
>
>
> Thanks,
>
> params
>
>
Re: Review Request: OOZIE-573: error message about misconfig in starting
time of coordinator and initial-instance of dataset
Posted by pa...@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2225/
-----------------------------------------------------------
(Updated 2011-10-17 21:24:33.839356)
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Changes
-------
Incorporated review feedback (replaced n with actual value).
Summary
-------
OOZIE-573: error message about misconfig in starting time of coordinator and initial-instance of dataset
Summary:
https://issues.apache.org/jira/browse/OOZIE-573
This addresses bug OOZIE-573.
https://issues.apache.org/jira/browse/OOZIE-573
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 1185323
Diff: https://reviews.apache.org/r/2225/diff
Testing
-------
Tested against current test cases.
Thanks,
params
Re: Review Request: OOZIE-573: error message about misconfig in starting
time of coordinator and initial-instance of dataset
Posted by pa...@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2225/
-----------------------------------------------------------
(Updated 2011-10-14 22:31:28.605814)
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Changes
-------
Log (warn) statements need to be added for both the cases when empty string is returned:
1) When coordinator action creation time (nominal time) is before the initial instance of dataset.
2) When coordinator action creation time (nominal time) is after the initial instance of dataset, but an attempt is made to fetch the current instance, coord:current(n) which works out to be before the initial instance of dataset.
Summary
-------
OOZIE-573: error message about misconfig in starting time of coordinator and initial-instance of dataset
Summary:
https://issues.apache.org/jira/browse/OOZIE-573
This addresses bug OOZIE-573.
https://issues.apache.org/jira/browse/OOZIE-573
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 1182589
Diff: https://reviews.apache.org/r/2225/diff
Testing
-------
Tested against current test cases.
Thanks,
params
Re: Review Request: OOZIE-573: error message about misconfig in starting
time of coordinator and initial-instance of dataset
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2225/#review2413
-----------------------------------------------------------
Committed
- Mohammad
On 2011-10-05 21:07:07, params wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2225/
> -----------------------------------------------------------
>
> (Updated 2011-10-05 21:07:07)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> OOZIE-573: error message about misconfig in starting time of coordinator and initial-instance of dataset
>
> Summary:
> https://issues.apache.org/jira/browse/OOZIE-573
>
>
> This addresses bug OOZIE-573.
> https://issues.apache.org/jira/browse/OOZIE-573
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 1179437
> trunk/release-log.txt 1179437
>
> Diff: https://reviews.apache.org/r/2225/diff
>
>
> Testing
> -------
>
> Tested against current test cases.
>
>
> Thanks,
>
> params
>
>