You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/08/11 02:20:32 UTC
[kudu-CR] KUDU-3599 more robust way of updating tablet copy metrics
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21658
Change subject: KUDU-3599 more robust way of updating tablet copy metrics
......................................................................
KUDU-3599 more robust way of updating tablet copy metrics
This patch addresses ThreadSanitizer warnings on accessing recently
introduced RemoteTabletCopySourceSession::start_time_ field. That's
done by using already existing field TabletCopySourceSession::init_once_
of the thread-safe KuduOnceDynamic type to check if the 'start_time_'
has already been initialized.
This is a follow-up to d370e0e4511508790c065340a52242ee09ecfea3.
Change-Id: Id78d0df426fcbc5711624eb94b06babd8689d2ba
---
M src/kudu/tserver/tablet_copy_source_session.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/21658/1
--
To view, visit http://gerrit.cloudera.org:8080/21658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id78d0df426fcbc5711624eb94b06babd8689d2ba
Gerrit-Change-Number: 21658
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] KUDU-3599 more robust way of updating tablet copy metrics
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21658 )
Change subject: KUDU-3599 more robust way of updating tablet copy metrics
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/404/
--
To view, visit http://gerrit.cloudera.org:8080/21658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id78d0df426fcbc5711624eb94b06babd8689d2ba
Gerrit-Change-Number: 21658
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 11 Aug 2024 02:20:41 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3599 more robust way of updating tablet copy metrics
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21658 )
Change subject: KUDU-3599 more robust way of updating tablet copy metrics
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id78d0df426fcbc5711624eb94b06babd8689d2ba
Gerrit-Change-Number: 21658
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sun, 11 Aug 2024 14:21:25 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3599 more robust way of updating tablet copy metrics
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21658 )
Change subject: KUDU-3599 more robust way of updating tablet copy metrics
......................................................................
Patch Set 1: Verified+1
unrelated Java test failure (TSAN): org.apache.kudu.client.TestSecurity, see KUDU-2880
--
To view, visit http://gerrit.cloudera.org:8080/21658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id78d0df426fcbc5711624eb94b06babd8689d2ba
Gerrit-Change-Number: 21658
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 12 Aug 2024 04:23:43 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3599 more robust way of updating tablet copy metrics
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/21658 )
Change subject: KUDU-3599 more robust way of updating tablet copy metrics
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id78d0df426fcbc5711624eb94b06babd8689d2ba
Gerrit-Change-Number: 21658
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 12 Aug 2024 02:22:34 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3599 more robust way of updating tablet copy metrics
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21658 )
Change subject: KUDU-3599 more robust way of updating tablet copy metrics
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/404/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id78d0df426fcbc5711624eb94b06babd8689d2ba
Gerrit-Change-Number: 21658
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sun, 11 Aug 2024 03:22:47 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3599 more robust way of updating tablet copy metrics
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21658 )
Change subject: KUDU-3599 more robust way of updating tablet copy metrics
......................................................................
KUDU-3599 more robust way of updating tablet copy metrics
This patch addresses ThreadSanitizer warnings on accessing recently
introduced RemoteTabletCopySourceSession::start_time_ field. That's
done by using already existing field TabletCopySourceSession::init_once_
of the thread-safe KuduOnceDynamic type to check if the 'start_time_'
has already been initialized.
This is a follow-up to d370e0e4511508790c065340a52242ee09ecfea3.
Change-Id: Id78d0df426fcbc5711624eb94b06babd8689d2ba
Reviewed-on: http://gerrit.cloudera.org:8080/21658
Reviewed-by: Yingchun Lai <la...@apache.org>
Reviewed-by: KeDeng <kd...@gmail.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/tserver/tablet_copy_source_session.cc
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Yingchun Lai: Looks good to me, approved
KeDeng: Looks good to me, but someone else must approve
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/21658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id78d0df426fcbc5711624eb94b06babd8689d2ba
Gerrit-Change-Number: 21658
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] KUDU-3599 more robust way of updating tablet copy metrics
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-3599 more robust way of updating tablet copy metrics
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/21658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id78d0df426fcbc5711624eb94b06babd8689d2ba
Gerrit-Change-Number: 21658
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>