You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Karishma Gulati <gu...@yahoo.com> on 2015/02/24 12:50:39 UTC
Review Request 31353:
https://issues.apache.org/jira/browse/FALCON-1046
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31353/
-----------------------------------------------------------
Review request for Falcon.
Repository: falcon-git
Description
-------
More details can be found at : https://issues.apache.org/jira/browse/FALCON-430.
Example Test Case:
FeedA Scheduled by U1, Dependent Process by U2, FeedA Updated by U1 -> New Bundle for FeedA with U1, New Bundle for Process with U2 (and not U1) created.
Similarly, have identified a couple of other test cases.
Diffs
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java 4787ef1
Diff: https://reviews.apache.org/r/31353/diff/
Testing
-------
Added Tests to Authorization Test.
Thanks,
Karishma Gulati
Re: Review Request 31353: [Falcon-1046] Add test for process update
with user feature
Posted by Karishma Gulati <gu...@yahoo.com>.
> On Feb. 26, 2015, 5:04 a.m., samarth gupta wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java, line 699
> > <https://reviews.apache.org/r/31353/diff/1/?file=873928#file873928line699>
> >
> > all these test seems to be disabled. If they are passing now can we enable them ?
Enabled the tests that I know are passing for sure.
- Karishma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31353/#review74211
-----------------------------------------------------------
On Feb. 24, 2015, 1:12 p.m., Karishma Gulati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31353/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 1:12 p.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> More details can be found at : https://issues.apache.org/jira/browse/FALCON-430.
> Example Test Case:
> FeedA Scheduled by U1, Dependent Process by U2, FeedA Updated by U1 -> New Bundle for FeedA with U1, New Bundle for Process with U2 (and not U1) created.
>
> Similarly, have identified a couple of other test cases.
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java 4787ef1
>
> Diff: https://reviews.apache.org/r/31353/diff/
>
>
> Testing
> -------
>
> Added Tests to Authorization Test.
>
>
> Thanks,
>
> Karishma Gulati
>
>
Re: Review Request 31353: [Falcon-1046] Add test for process update
with user feature
Posted by Karishma Gulati <gu...@yahoo.com>.
> On Feb. 26, 2015, 5:04 a.m., samarth gupta wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java, line 648
> > <https://reviews.apache.org/r/31353/diff/1/?file=873928#file873928line648>
> >
> > how was the validity set till now ? why do we need to set it explicitly now ?
The validity of the process-template in ELBundle ends in 2011. So update doesn't work for that process. Hence you'll see that all tests that update the process are explicitly setting the validity of the process as well.
- Karishma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31353/#review74211
-----------------------------------------------------------
On Feb. 24, 2015, 1:12 p.m., Karishma Gulati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31353/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 1:12 p.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> More details can be found at : https://issues.apache.org/jira/browse/FALCON-430.
> Example Test Case:
> FeedA Scheduled by U1, Dependent Process by U2, FeedA Updated by U1 -> New Bundle for FeedA with U1, New Bundle for Process with U2 (and not U1) created.
>
> Similarly, have identified a couple of other test cases.
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java 4787ef1
>
> Diff: https://reviews.apache.org/r/31353/diff/
>
>
> Testing
> -------
>
> Added Tests to Authorization Test.
>
>
> Thanks,
>
> Karishma Gulati
>
>
Re: Review Request 31353: [Falcon-1046] Add test for process update
with user feature
Posted by samarth gupta <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31353/#review74211
-----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java
<https://reviews.apache.org/r/31353/#comment120730>
how was the validity set till now ? why do we need to set it explicitly now ?
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java
<https://reviews.apache.org/r/31353/#comment120731>
all these test seems to be disabled. If they are passing now can we enable them ?
- samarth gupta
On Feb. 24, 2015, 1:12 p.m., Karishma Gulati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31353/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 1:12 p.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> More details can be found at : https://issues.apache.org/jira/browse/FALCON-430.
> Example Test Case:
> FeedA Scheduled by U1, Dependent Process by U2, FeedA Updated by U1 -> New Bundle for FeedA with U1, New Bundle for Process with U2 (and not U1) created.
>
> Similarly, have identified a couple of other test cases.
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java 4787ef1
>
> Diff: https://reviews.apache.org/r/31353/diff/
>
>
> Testing
> -------
>
> Added Tests to Authorization Test.
>
>
> Thanks,
>
> Karishma Gulati
>
>
Re: Review Request 31353: [Falcon-1046] Add test for process update
with user feature
Posted by Karishma Gulati <gu...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31353/
-----------------------------------------------------------
(Updated Feb. 27, 2015, 10:09 a.m.)
Review request for Falcon.
Repository: falcon-git
Description
-------
More details can be found at : https://issues.apache.org/jira/browse/FALCON-430.
Example Test Case:
FeedA Scheduled by U1, Dependent Process by U2, FeedA Updated by U1 -> New Bundle for FeedA with U1, New Bundle for Process with U2 (and not U1) created.
Similarly, have identified a couple of other test cases.
Diffs (updated)
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java 4787ef1
Diff: https://reviews.apache.org/r/31353/diff/
Testing
-------
Added Tests to Authorization Test.
Thanks,
Karishma Gulati
Re: Review Request 31353: [Falcon-1046] Add test for process update
with user feature
Posted by Karishma Gulati <gu...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31353/
-----------------------------------------------------------
(Updated Feb. 24, 2015, 1:12 p.m.)
Review request for Falcon.
Summary (updated)
-----------------
[Falcon-1046] Add test for process update with user feature
Repository: falcon-git
Description
-------
More details can be found at : https://issues.apache.org/jira/browse/FALCON-430.
Example Test Case:
FeedA Scheduled by U1, Dependent Process by U2, FeedA Updated by U1 -> New Bundle for FeedA with U1, New Bundle for Process with U2 (and not U1) created.
Similarly, have identified a couple of other test cases.
Diffs
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java 4787ef1
Diff: https://reviews.apache.org/r/31353/diff/
Testing
-------
Added Tests to Authorization Test.
Thanks,
Karishma Gulati