[GitHub] [beam] ecapoccia commented on a change in pull request #11037: [BEAM-9434] performance improvements reading many Avro files in S3

[GitBox <gi...@apache.org>]

ecapoccia commented on a change in pull request #11037: [BEAM-9434] performance improvements reading many Avro files in S3
URL: https://github.com/apache/beam/pull/11037#discussion_r404372090
 
 

 ##########
 File path: runners/spark/src/main/java/org/apache/beam/runners/spark/translation/GroupCombineFunctions.java
 ##########
 @@ -184,11 +184,11 @@
 
   /** An implementation of {@link Reshuffle} for the Spark runner. */
   public static <T> JavaRDD<WindowedValue<T>> reshuffle(
-      JavaRDD<WindowedValue<T>> rdd, WindowedValueCoder<T> wvCoder) {
+      JavaRDD<WindowedValue<T>> rdd, WindowedValueCoder<T> wvCoder, int numPartitions) {
 
 Review comment:
   @iemejia @lukecwik ok will do the changes. The only reason why I opted to change only the batch pipeline for Spark is that it is the only one I am in a position to thoroughly test for real. However, analysing the code suggests that changing all pipelines does not harm, so I'll go for the suggested changes.
   Will submit the squashed PR soon. In the meantime, thanks for the review.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services