[jira] [Commented] (HADOOP-11341) Check if user is present in default key ACL if user does not have explicit key ACLS

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-11341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226797#comment-14226797 ] 

Hadoop QA commented on HADOOP-11341:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12683909/HADOOP-11341.1.patch
  against trunk revision 8f1454c.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-kms.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5125//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5125//console

This message is automatically generated.

> Check if user is present in default key ACL if user does not have explicit key ACLS
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-11341
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11341
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: kms, security
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: HADOOP-11341.1.patch
>
>
> As reported by [~dian.fu] :
> Key based ACL in KMS is currently implemented as whitelist. So if I configure as follows in kms-acl.xml,
> {code}
>  <property>
>     <name>key.acl.testKey.DECRYPT_EEK</name>
>     <value>testUser</value>
>   </property>
> {code}, then only {{testUser}} user can do {{DECRYPT_EEK}} call on key {{testKey}}. If I want {{yarn}} user can also do {{DECRYPT_EEK}} call on {{testKey}} key, I need add {{yarn}} user to the above configuration value manually. This means that if I want to configure key based ACL({{DECRYPT_EEK}}) for {{some key}}, I need also add {{yarn}} user to configuration {{DECRYPT_EEK}} for that key. As I don't know if {{yarn}} user will later need to do {{DECRYPT_EEK}} for this key.. This is inconvenient and tricky.
> This can be alleviated by slightly modifying the key ACL logic in KMS first checks if the user, in this case {{yarn}}, is present in {{key.acl.<key-name>.<OP-name>}} list. And if not, then also check if the user is present in {{default.key.acl.<OP-name>}}. If yes, then grant access.. else deny.
> Currently,  {{default.key.acl.<OP-name>}} is consulted only if NO {{key.acl.<key-name>.<OP-name>}} is specified.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)