[jira] Commented: (ORCHESTRA-39) Conversations are not cleaned up if session timeout is near conversation timeout

["Simon Kitching (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/ORCHESTRA-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689192#action_12689192 ] 

Simon Kitching commented on ORCHESTRA-39:
-----------------------------------------

This looks pretty good to me.

One minor note: I think new method ConversationWiperThread.removeAndInvalidateConversationManager is better as a private method on the ConversationManagerSessionListener class.

There is also a spelling mistake in this method name:
  removeAndInvalidateConversationContextAndChilden
Childen --> Children

Possibly new methods
  protected ConversationManager.removeAndInvalidateAllConversationContexts
  private ConversationManager.removeAndInvalidateConversationContextAndChildren
could be public. There are already public methods that act on the "flat" contexts, and we expose the concept of "child contexts" through public APIs. So I don't see any reason not to make these new methods generally available. I suggest making them public now, and if anyone (eg mario) objects, we can reduce the visibility before the next release.

If you're ok with making these minor changes, then please go ahead and commit your patch...and thanks for the fix!

> Conversations are not cleaned up if session timeout is near conversation timeout
> --------------------------------------------------------------------------------
>
>                 Key: ORCHESTRA-39
>                 URL: https://issues.apache.org/jira/browse/ORCHESTRA-39
>             Project: MyFaces Orchestra
>          Issue Type: Improvement
>          Components: Conversation
>    Affects Versions: 1.3.1
>            Reporter: Bernd Bohmann
>            Assignee: Simon Kitching
>         Attachments: ORCHESTRA-39.patch
>
>
> The ConversationManager can be removed by the ConversationManagerSessionListener before the ConversationWiperThread has timed out the Conversations. This can cause open PersistenceContext if the session timed out or is invalidated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.