[GitHub] [spark] zhengruifeng commented on a change in pull request #27015: [SPARK-30358][ML] ML expose predictRaw and predictProbability

[GitBox <gi...@apache.org>]

zhengruifeng commented on a change in pull request #27015: [SPARK-30358][ML] ML expose predictRaw and predictProbability
URL: https://github.com/apache/spark/pull/27015#discussion_r361825722
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
 ##########
 @@ -198,7 +198,8 @@ class DecisionTreeRegressionModel private[ml] (
   }
 
   /** We need to update this function if we ever add other impurity measures. */
-  protected def predictVariance(features: Vector): Double = {
+  @Since("3.0.0")
+  def predictVariance(features: Vector): Double = {
 
 Review comment:
   You are right. I think we do not need this method for now. I will remove it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org