[jira] [Commented] (HBASE-3828) region server stuck in waitOnAllRegionsToClose

["Prakash Khemani (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-3828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026776#comment-13026776 ] 

Prakash Khemani commented on HBASE-3828:
----------------------------------------

The regionserver is not able to exit because the rs thread is stuck here

"regionserver60020" prio=10 tid=0x00002ab2b039e000 nid=0x760a waiting on condition [0x000000004365e000]
java.lang.Thread.State: TIMED_WAITING (sleeping)
at java.lang.Thread.sleep(Native Method)
at org.apache.hadoop.hbase.util.Threads.sleep(Threads.java:126)
at org.apache.hadoop.hbase.regionserver.HRegionServer.waitOnAllRegionsToClose(HRegionServer.java:736)
at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:689)
at java.lang.Thread.run(Thread.java:619)


This has happened a few times in my cluster.

===
In OpenRegionHandler

  @Override
  public void process() throws IOException {
    final String name = regionInfo.getRegionNameAsString();
    LOG.debug("Processing open of " + name);
    if (this.server.isStopped() || this.rsServices.isStopping()) {
      LOG.info("Server stopping or stopped, skipping open of " + name);
      return;
    }

Is the above check sufficient to prevent a region from being opened when the rs is stopping/aborting ... no right? A lock.readLock.lock() has to be acquired ... or shouldn't these guys do a startRegionOperation() as well?


===

Also in close region handler there is this code

    int expectedVersion = FAILED;
    if (this.zk) {
      expectedVersion = setClosingState();
      if (expectedVersion == FAILED) return;
    }

This should remove from onlineRegions() before returning?


> region server stuck in waitOnAllRegionsToClose
> ----------------------------------------------
>
>                 Key: HBASE-3828
>                 URL: https://issues.apache.org/jira/browse/HBASE-3828
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Prakash Khemani
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira